You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by ro...@apache.org on 2022/10/13 12:13:55 UTC
[activemq-artemis] branch main updated: ARTEMIS-4048: stop -all client modules needlessly grabbing their own -SNAPSHOT sources during build
This is an automated email from the ASF dual-hosted git repository.
robbie pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git
The following commit(s) were added to refs/heads/main by this push:
new 8cba446e2b ARTEMIS-4048: stop -all client modules needlessly grabbing their own -SNAPSHOT sources during build
8cba446e2b is described below
commit 8cba446e2b1fd2259c1b07a960adcb47158c666c
Author: Robbie Gemmell <ro...@apache.org>
AuthorDate: Thu Oct 13 13:06:09 2022 +0100
ARTEMIS-4048: stop -all client modules needlessly grabbing their own -SNAPSHOT sources during build
- Always produce the original basically-empty sources jar for the
module, before the shading, meaning its always available.
- Do the same for the main jar, to avoid the shading operating on a
previously-shaded renamed output from a prior run if not cleaning.
---
artemis-core-client-all/pom.xml | 39 ++++++++++++++++++++++++++++++++++++++
artemis-jakarta-client-all/pom.xml | 39 ++++++++++++++++++++++++++++++++++++++
artemis-jms-client-all/pom.xml | 39 ++++++++++++++++++++++++++++++++++++++
3 files changed, 117 insertions(+)
diff --git a/artemis-core-client-all/pom.xml b/artemis-core-client-all/pom.xml
index 374aac1784..5aa207c9ef 100644
--- a/artemis-core-client-all/pom.xml
+++ b/artemis-core-client-all/pom.xml
@@ -40,7 +40,46 @@
</dependencies>
<build>
+ <pluginManagement>
+ <plugins>
+ <!-- Override root pom definition, so as to ensure the shading has a fresh base sources jar
+ for the module before shading, with nothing much in it, and doesnt instead grab a large
+ already-shaded remote snapshot, possibly each day (local) or on every build (CI) -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-source-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>attach-sources</id>
+ <phase>package</phase>
+ <goals>
+ <goal>jar-no-fork</goal>
+ </goals>
+ <configuration>
+ <forceCreation>true</forceCreation>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </pluginManagement>
+
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>default-jar</id>
+ <configuration>
+ <!-- Ensures the shading is always working upon a fresh base jar, which has
+ nothing much in it, rather than potentially working on already-shaded
+ output still present from prior runs and renamed to have the base name -->
+ <forceCreation>true</forceCreation>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
diff --git a/artemis-jakarta-client-all/pom.xml b/artemis-jakarta-client-all/pom.xml
index 83c6120dbb..f4aed5828c 100644
--- a/artemis-jakarta-client-all/pom.xml
+++ b/artemis-jakarta-client-all/pom.xml
@@ -41,7 +41,46 @@
</dependencies>
<build>
+ <pluginManagement>
+ <plugins>
+ <!-- Override root pom definition, so as to ensure the shading has a fresh base sources jar
+ for the module before shading, with nothing much in it, and doesnt instead grab a large
+ already-shaded remote snapshot, possibly each day (local) or on every build (CI) -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-source-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>attach-sources</id>
+ <phase>package</phase>
+ <goals>
+ <goal>jar-no-fork</goal>
+ </goals>
+ <configuration>
+ <forceCreation>true</forceCreation>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </pluginManagement>
+
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>default-jar</id>
+ <configuration>
+ <!-- Ensures the shading is always working upon a fresh base jar, which has
+ nothing much in it, rather than potentially working on already-shaded
+ output still present from prior runs and renamed to have the base name -->
+ <forceCreation>true</forceCreation>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
diff --git a/artemis-jms-client-all/pom.xml b/artemis-jms-client-all/pom.xml
index 3a253659b2..09efc6aabf 100644
--- a/artemis-jms-client-all/pom.xml
+++ b/artemis-jms-client-all/pom.xml
@@ -40,7 +40,46 @@
</dependencies>
<build>
+ <pluginManagement>
+ <plugins>
+ <!-- Override root pom definition, so as to ensure the shading has a fresh base sources jar
+ for the module before shading, with nothing much in it, and doesnt instead grab a large
+ already-shaded remote snapshot, possibly each day (local) or on every build (CI) -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-source-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>attach-sources</id>
+ <phase>package</phase>
+ <goals>
+ <goal>jar-no-fork</goal>
+ </goals>
+ <configuration>
+ <forceCreation>true</forceCreation>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </pluginManagement>
+
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>default-jar</id>
+ <configuration>
+ <!-- Ensures the shading is always working upon a fresh base jar, which has
+ nothing much in it, rather than potentially working on already-shaded
+ output still present from prior runs and renamed to have the base name -->
+ <forceCreation>true</forceCreation>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>