You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/12/13 20:45:04 UTC
Review Request 54591: Introduced `WindowsFD` class which is analogous
to an `int` in POSIX.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54591/
-----------------------------------------------------------
Review request for mesos and Daniel Pravat.
Repository: mesos
Description
-------
In POSIX the socket, pipe and a file are represented by the `int` type.
In Windows:
- A socket is kept in a `SOCKET` type (64 bit wide)
- A pipe or a WinAPI file descriptor in a `HANDLE` (64 bit wide)
- A CRT file descriptor in an `int`
The `WindowsFD` class is a type that brings all of these things
together and behaves analogously to an `int` in POSIX.
Diffs
-----
3rdparty/stout/include/stout/os.hpp cdcbbf488d110e33e796fb0b7414793391761abf
3rdparty/stout/include/stout/os/int_fd.hpp PRE-CREATION
3rdparty/stout/include/stout/os/windows/fd.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/54591/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 54591: Introduced `WindowsFD` class which is
analogous to an `int` in POSIX.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54591/
-----------------------------------------------------------
(Updated Dec. 20, 2016, 2:29 p.m.)
Review request for mesos and Daniel Pravat.
Changes
-------
- Fixed formatting
- Added comparison operators to allow closer treatment to `int` (as discussed with BenH)
Repository: mesos
Description
-------
In POSIX the socket, pipe and a file are represented by the `int` type.
In Windows:
- A socket is kept in a `SOCKET` type (64 bit wide)
- A pipe or a WinAPI file descriptor in a `HANDLE` (64 bit wide)
- A CRT file descriptor in an `int`
The `WindowsFD` class is a type that brings all of these things
together and behaves analogously to an `int` in POSIX.
Diffs (updated)
-----
3rdparty/stout/include/stout/os.hpp 63265eed28d7345dfa18ac1c5a22ef58a7902c62
3rdparty/stout/include/stout/os/int_fd.hpp PRE-CREATION
3rdparty/stout/include/stout/os/windows/fd.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/54591/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 54591: Introduced `WindowsFD` class which is
analogous to an `int` in POSIX.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54591/
-----------------------------------------------------------
(Updated Dec. 15, 2016, 5:41 p.m.)
Review request for mesos and Daniel Pravat.
Repository: mesos
Description
-------
In POSIX the socket, pipe and a file are represented by the `int` type.
In Windows:
- A socket is kept in a `SOCKET` type (64 bit wide)
- A pipe or a WinAPI file descriptor in a `HANDLE` (64 bit wide)
- A CRT file descriptor in an `int`
The `WindowsFD` class is a type that brings all of these things
together and behaves analogously to an `int` in POSIX.
Diffs (updated)
-----
3rdparty/stout/include/stout/os.hpp 63265eed28d7345dfa18ac1c5a22ef58a7902c62
3rdparty/stout/include/stout/os/int_fd.hpp PRE-CREATION
3rdparty/stout/include/stout/os/windows/fd.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/54591/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 54591: Introduced `WindowsFD` class which is
analogous to an `int` in POSIX.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54591/
-----------------------------------------------------------
(Updated Dec. 14, 2016, 3:50 p.m.)
Review request for mesos and Daniel Pravat.
Changes
-------
Added documentation.
Repository: mesos
Description
-------
In POSIX the socket, pipe and a file are represented by the `int` type.
In Windows:
- A socket is kept in a `SOCKET` type (64 bit wide)
- A pipe or a WinAPI file descriptor in a `HANDLE` (64 bit wide)
- A CRT file descriptor in an `int`
The `WindowsFD` class is a type that brings all of these things
together and behaves analogously to an `int` in POSIX.
Diffs (updated)
-----
3rdparty/stout/include/stout/os.hpp 63265eed28d7345dfa18ac1c5a22ef58a7902c62
3rdparty/stout/include/stout/os/int_fd.hpp PRE-CREATION
3rdparty/stout/include/stout/os/windows/fd.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/54591/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 54591: Introduced `WindowsFD` class which is
analogous to an `int` in POSIX.
Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54591/#review159213
-----------------------------------------------------------
Ship it!
Ship It!
- Daniel Pravat
On Dec. 13, 2016, 8:45 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54591/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2016, 8:45 p.m.)
>
>
> Review request for mesos and Daniel Pravat.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In POSIX the socket, pipe and a file are represented by the `int` type.
> In Windows:
> - A socket is kept in a `SOCKET` type (64 bit wide)
> - A pipe or a WinAPI file descriptor in a `HANDLE` (64 bit wide)
> - A CRT file descriptor in an `int`
>
> The `WindowsFD` class is a type that brings all of these things
> together and behaves analogously to an `int` in POSIX.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os.hpp cdcbbf488d110e33e796fb0b7414793391761abf
> 3rdparty/stout/include/stout/os/int_fd.hpp PRE-CREATION
> 3rdparty/stout/include/stout/os/windows/fd.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/54591/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>