You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2014/07/21 09:16:59 UTC
[GitHub] incubator-brooklyn pull request: Workaround for builds.apache.org ...
GitHub user neykov opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/80
Workaround for builds.apache.org CI
The build on builds.apache.org fails due to the wrong nodejs binary being used.
Until nodejs-maven-plugin is fixed (see https://github.com/skwakman/nodejs-maven-plugin/issues/8) don't use nodejs with the requirejs optimizer.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/incubator-brooklyn builds.apache.org-workaround
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/80.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #80
----
commit c5c0f961829ad952e6fa35b624ac6ecd05637ca3
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2014-07-21T07:14:42Z
Workaround for builds.apache.org CI
The build on builds.apache.org fails due to the wrong nodejs binary being used.
Until nodejs-maven-plugin is fixed don't use nodejs with the requirejs optimizer.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Workaround for builds.apache.org ...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/80#issuecomment-50025174
This is good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Workaround for builds.apache.org ...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/80#issuecomment-49708029
@sjcorbett's testing showed that Rhino is not reliable on Linux (stack overflow).
Here is an alternative workaround which uses nodejs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Workaround for builds.apache.org ...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/80#discussion_r15218738
--- Diff: usage/jsgui/src/build/nodejs ---
@@ -0,0 +1,12 @@
+#!/bin/sh
--- End diff --
Probably worth a comment explaining what it's for too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Workaround for builds.apache.org ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/80
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Workaround for builds.apache.org ...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/80#discussion_r15218722
--- Diff: usage/jsgui/src/build/nodejs ---
@@ -0,0 +1,12 @@
+#!/bin/sh
--- End diff --
File is missing the Apache header
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Workaround for builds.apache.org ...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/80#issuecomment-49927351
Addressed @sjcorbett's comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Workaround for builds.apache.org ...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/80#issuecomment-49718667
This is good once the license header is added to the nodejs script.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---