You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by "ashishvijaywargiya (via GitHub)" <gi...@apache.org> on 2026/08/21 16:07:27 UTC

[PR] Restructure example component's test files and rename JUnit3-style test class [ofbiz-plugins]

ashishvijaywargiya opened a new pull request, #372:
URL: https://github.com/apache/ofbiz-plugins/pull/372

   Restructures the example component's test-related files for clarity:
   
   - Moves `ExampleTestRunServices.groovy` from `src/main/groovy` to `src/test/groovy`, since it only exists to trigger/poll test runs.
   - Moves the Test Run Services block in `services.xml` to the end of the file and updates its location attributes to match.
   - Moves `ExampleJupiterTests.groovy` up one directory (out of the `jupiter/` subfolder) since the class name already conveys its purpose; updates its package declaration and the `jupiter-test-suite` class-name in `tests.xml` to match.
   - Renames `ExampleTests.groovy` to `ExampleJUnit3Tests.groovy`, then to `ExampleOldJUnit3Tests.groovy`, to make the file name convey that it's the old JUnit3-style test class, as a counterpart to `ExampleJupiterTests.groovy`. Updates the class name, constructor, `tests.xml`'s `junit-test-suite` class-name, and the doc-comment reference in `ExampleJupiterTests.groovy` accordingly.
   - Renames the `example-tests-groovy` test-case in `tests.xml` to `example-tests-junit3` to match.
   - Restructures `ExampleJupiterTests`: inlines the `createAndAssertExample` helper directly into `shouldCreateExample`/`shouldUpdateExample`, removes the redundant `shouldCreateExampleWithParams` test, and replaces the disabled `shouldUpdateExampleUnderConcurrentLoad` stub with a real create-then-delete-then-verify `shouldDeleteExample` test (kept `@Disabled` as a documented sample).
   
   Verified locally: `ofbiz --test component=example suitename=example-tests` passes (18 tests, 0 failed, 0 errors).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Restructure example component's test files and rename JUnit3-style test class [ofbiz-plugins]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.

sonarqubecloud[bot] commented on PR #372:
URL: https://github.com/apache/ofbiz-plugins/pull/372#issuecomment-5372320229

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=372) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [8 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=372&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=372&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=372&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=372&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=372&metric=new_duplicated_lines_density&view=list)  
     
   <!-- sqra-placement-anchor -->
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=372)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Restructure example component's test files and rename JUnit3-style test class [ofbiz-plugins]

Posted by "ashishvijaywargiya (via GitHub)" <gi...@apache.org>.

ashishvijaywargiya merged PR #372:
URL: https://github.com/apache/ofbiz-plugins/pull/372


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org