You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by we...@apache.org on 2015/08/31 22:45:38 UTC
incubator-reef git commit: [REEF-661] Remove obsolete APIs from
o.a.r.Network (.NET)
Repository: incubator-reef
Updated Branches:
refs/heads/master 38e1e7051 -> da5365091
[REEF-661] Remove obsolete APIs from o.a.r.Network (.NET)
This removes/converts to private obsolete constructors of NameClient and
NameServer
JIRA:
[REEF-661](https://issues.apache.org/jira/browse/REEF-661)
Pull Request:
Closes #448
Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/da536509
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/da536509
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/da536509
Branch: refs/heads/master
Commit: da53650916fe44967363daca8e965fa26fbcc974
Parents: 38e1e70
Author: Mariia Mykhailova <mi...@gmail.com>
Authored: Mon Aug 31 11:19:29 2015 -0700
Committer: Markus Weimer <we...@apache.org>
Committed: Mon Aug 31 13:44:32 2015 -0700
----------------------------------------------------------------------
.../cs/Org.Apache.REEF.Network/Naming/NameClient.cs | 16 +---------------
.../cs/Org.Apache.REEF.Network/Naming/NameServer.cs | 3 +--
2 files changed, 2 insertions(+), 17 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/da536509/lang/cs/Org.Apache.REEF.Network/Naming/NameClient.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Network/Naming/NameClient.cs b/lang/cs/Org.Apache.REEF.Network/Naming/NameClient.cs
index 4629ad1..27351be 100644
--- a/lang/cs/Org.Apache.REEF.Network/Naming/NameClient.cs
+++ b/lang/cs/Org.Apache.REEF.Network/Naming/NameClient.cs
@@ -64,9 +64,8 @@ namespace Org.Apache.REEF.Network.Naming
/// </summary>
/// <param name="remoteAddress">The ip address of the NameServer</param>
/// <param name="remotePort">The port of the NameServer</param>
- [Obsolete("This constructor will be made private in 0.13 version", false)]
[Inject]
- public NameClient(
+ private NameClient(
[Parameter(typeof (NamingConfigurationOptions.NameServerAddress))] string remoteAddress,
[Parameter(typeof (NamingConfigurationOptions.NameServerPort))] int remotePort)
{
@@ -96,19 +95,6 @@ namespace Org.Apache.REEF.Network.Naming
}
/// <summary>
- /// Constructs a NameClient to register, lookup, and unregister IPEndpoints
- /// with the NameServer.
- /// </summary>
- /// <param name="remoteEndpoint">The endpoint of the NameServer</param>
- [Obsolete("This constructor will be removed in the 0.13 version", false)]
- public NameClient(IPEndPoint remoteEndpoint)
- {
- Initialize(remoteEndpoint);
- _cache = TangFactory.GetTang().NewInjector().GetInstance<NameCache>();
- _disposed = false;
- }
-
- /// <summary>
/// Synchronously registers the identifier with the NameService.
/// Overwrites the previous mapping if the identifier has already
/// been registered.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/da536509/lang/cs/Org.Apache.REEF.Network/Naming/NameServer.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Network/Naming/NameServer.cs b/lang/cs/Org.Apache.REEF.Network/Naming/NameServer.cs
index 47d17f5..585cc35 100644
--- a/lang/cs/Org.Apache.REEF.Network/Naming/NameServer.cs
+++ b/lang/cs/Org.Apache.REEF.Network/Naming/NameServer.cs
@@ -54,9 +54,8 @@ namespace Org.Apache.REEF.Network.Naming
/// <param name="tcpPortProvider">If port is 0, this interface provides
/// a port range to try.
/// </param>
- [Obsolete("Please use TANG injection instead.")]
[Inject]
- public NameServer(
+ private NameServer(
[Parameter(typeof(NamingConfigurationOptions.NameServerPort))] int port,
ITcpPortProvider tcpPortProvider)
{