You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/19 03:21:14 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #385: apps/MAKE: Add register staging to context

xiaoxiang781216 commented on a change in pull request #385:
URL: https://github.com/apache/incubator-nuttx-apps/pull/385#discussion_r491262420



##########
File path: Makefile
##########
@@ -152,13 +156,12 @@ endif # CONFIG_BUILD_KERNEL
 dirlinks:
 	$(Q) $(MAKE) -C platform dirlinks TOPDIR="$(TOPDIR)" APPDIR="$(APPDIR)"
 
-context_rest: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_context)
+context_all: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_context)
+register_all: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_register)
 
-context_serialize:
-	$(Q) $(MAKE) -C builtin context TOPDIR="$(TOPDIR)" APPDIR="$(APPDIR)"

Review comment:
       @v01d $(CONFIGURED_APPS) actually contain "builtin", here is the code from https://github.com/apache/incubator-nuttx-apps/blob/master/builtin/Make.defs#L37:
   ```
   ifeq ($(CONFIG_BUILTIN),y)
   CONFIGURED_APPS += $(APPDIR)/builtin
   endif
   ```
   
   the old Makefile build the context target of builtin twice, this patch fix this issue by removing the explicit invocation.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org