You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/06/16 22:21:43 UTC
[Impala-ASF-CR] IMPALA-9861: use [[nodiscard]] in gcc
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16087
Change subject: IMPALA-9861: use [[nodiscard]] in gcc
......................................................................
IMPALA-9861: use [[nodiscard]] in gcc
This was unblocked by the GCC 7 upgrade.
Change-Id: I5290ee36388baef3d43adbde7c684125dbcf3bec
---
M be/src/common/compiler-util.h
M be/src/common/status.h
2 files changed, 1 insertion(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/16087/1
--
To view, visit http://gerrit.cloudera.org:8080/16087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5290ee36388baef3d43adbde7c684125dbcf3bec
Gerrit-Change-Number: 16087
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9861: use [[nodiscard]] in gcc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16087 )
Change subject: IMPALA-9861: use [[nodiscard]] in gcc
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6345/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5290ee36388baef3d43adbde7c684125dbcf3bec
Gerrit-Change-Number: 16087
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jun 2020 05:22:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9861: use [[nodiscard]] in gcc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16087 )
Change subject: IMPALA-9861: use [[nodiscard]] in gcc
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6010/
--
To view, visit http://gerrit.cloudera.org:8080/16087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5290ee36388baef3d43adbde7c684125dbcf3bec
Gerrit-Change-Number: 16087
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jun 2020 22:34:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9861: use [[nodiscard]] in gcc
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16087 )
Change subject: IMPALA-9861: use [[nodiscard]] in gcc
......................................................................
IMPALA-9861: use [[nodiscard]] in gcc
This was unblocked by the GCC 7 upgrade.
Tested by removing a RETURN_IF_ERROR and making sure there was a compile
error.
Change-Id: I5290ee36388baef3d43adbde7c684125dbcf3bec
---
M be/src/common/compiler-util.h
M be/src/common/status.h
2 files changed, 1 insertion(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/16087/2
--
To view, visit http://gerrit.cloudera.org:8080/16087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5290ee36388baef3d43adbde7c684125dbcf3bec
Gerrit-Change-Number: 16087
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9861: use [[nodiscard]] in gcc
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16087 )
Change subject: IMPALA-9861: use [[nodiscard]] in gcc
......................................................................
IMPALA-9861: use [[nodiscard]] in gcc
This was unblocked by the GCC 7 upgrade.
Tested by removing a RETURN_IF_ERROR and making sure there was a compile
error.
Change-Id: I5290ee36388baef3d43adbde7c684125dbcf3bec
Reviewed-on: http://gerrit.cloudera.org:8080/16087
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/common/compiler-util.h
M be/src/common/status.h
2 files changed, 1 insertion(+), 16 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5290ee36388baef3d43adbde7c684125dbcf3bec
Gerrit-Change-Number: 16087
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9861: use [[nodiscard]] in gcc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16087 )
Change subject: IMPALA-9861: use [[nodiscard]] in gcc
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6342/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5290ee36388baef3d43adbde7c684125dbcf3bec
Gerrit-Change-Number: 16087
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jun 2020 22:51:51 +0000
Gerrit-HasComments: No