[GitHub] [helix] xyuanlu commented on a diff in pull request #2359: Fix ZkClient retry logic for customized callback and test

["xyuanlu (via GitHub)" <gi...@apache.org>]

xyuanlu commented on code in PR #2359:
URL: https://github.com/apache/helix/pull/2359#discussion_r1093903861


##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/callback/ZkAsyncCallbacks.java:
##########
@@ -259,10 +276,15 @@ public int getRc() {
       return _rc;
     }
 
+    public String getPath() {
+      return _path;
+    }
+
     @Override
     public void notifyCallers() {
       LOG.warn("The callback {} has been cancelled.", this);
       markOperationDone();
+      handle();

Review Comment:
   Thanks for the suggestion. Putting handle() before markOperationDone() make sense. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org