You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/12/16 14:18:48 UTC

[GitHub] XD-DENG commented on a change in pull request #4324: [AIRFLOW-3327] Add location in BigQueryHook

XD-DENG commented on a change in pull request #4324: [AIRFLOW-3327] Add location in BigQueryHook
URL: https://github.com/apache/incubator-airflow/pull/4324#discussion_r241982427
 
 

 ##########
 File path: airflow/contrib/hooks/bigquery_hook.py
 ##########
 @@ -580,11 +587,18 @@ def run_query(self,
             by one or more columns. This is only available in combination with
             time_partitioning. The order of columns given determines the sort order.
         :type cluster_fields: list of str
+        :param location: The geographic location of the job. Required except for
+            US and EU. See details at
 
 Review comment:
   Hi @kaxil , curious what would happen if the BigQuery data is stored in a region location other than US/EU while user misses to specify `location`? How will the exception be like?
   
   
   `

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services