You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2018/08/09 05:46:29 UTC

[GitHub] zeppelin pull request #3119: ZEPPELIN-3681. Introduce NotebookService

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/3119

    ZEPPELIN-3681. Introduce NotebookService

    ### What is this PR for?
    This the first phase of refactoring work of ZEPPELIN-3288. This PR put all the notebook related operation into class NotebookService which called by both NotebookServer & NotebookRestApi.
    
    
    ### What type of PR is it?
    [Refactoring]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3288
    
    ### How should this be tested?
    * CI pass
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3681

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3119.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3119
    
----
commit 85d9a3987c37ee665d5e58c2993429fe6e7572bb
Author: Jeff Zhang <zj...@...>
Date:   2018-08-02T09:50:17Z

    ZEPPELIN-3681. Introduce NotebookService

----


---

[GitHub] zeppelin issue #3119: ZEPPELIN-3681. Introduce NotebookService

Posted by jongyoul <gi...@git.apache.org>.

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/3119
  
    Basically, I agree with the structure you imagine. This might have some style issues, but I don't think it's not a blocker for this stage. LGTM


---

[GitHub] zeppelin pull request #3119: ZEPPELIN-3681. Introduce NotebookService

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/3119


---

[GitHub] zeppelin issue #3119: ZEPPELIN-3681. Introduce NotebookService

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3119
  
    @jongyoul @felixcheung Could you help review it ? Thanks


---

[GitHub] zeppelin issue #3119: ZEPPELIN-3681. Introduce NotebookService

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3119
  
    Thanks @jongyoul I have addressed the comments


---