[GitHub] [griffin] chitralverma commented on a change in pull request #598: [GRIFFIN-369] Bug fix for avro format in Spark 2.3.x environment

[GitBox <gi...@apache.org>]

chitralverma commented on a change in pull request #598:
URL: https://github.com/apache/griffin/pull/598#discussion_r790411689



##########
File path: measure/src/main/scala/org/apache/griffin/measure/datasource/connector/batch/FileBasedDataConnector.scala
##########
@@ -79,7 +79,8 @@ case class FileBasedDataConnector(
     SupportedFormats.contains(format),
     s"Invalid format '$format' specified. Must be one of ${SupportedFormats.mkString("['", "', '", "']")}")
 
-  if (format.equalsIgnoreCase("avro") && sparkSession.version < "2.3.0") {
+  // built-in AVRO data source implementation is released in spark 2.4.0

Review comment:
       Suggestion:
   
   ```suggestion
     // Use old implementation for AVRO format if current spark version is not 2.4.x and above
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org