You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/06 13:37:05 UTC
[GitHub] [superset] gvee-uk opened a new pull request #16608: fix: Normalise `*.sh` File Endings
gvee-uk opened a new pull request #16608:
URL: https://github.com/apache/superset/pull/16608
### SUMMARY
Windows users encounter problems running the `docker-compose` commands
to run an instance of Superset.
The reason for this is line-endings for the `*.sh` files that are
mounted and used in the `command` sections for the superset images.
Many Windows users will check the repository out with line endings set
to `CRLF`. When mounted in to the *nix-based containers, these line
endings are not understood, leading to errors such as:
```text
/usr/bin/env: bash\r: No such file or directory
```
The addition of a `.gitattributes` file resolves this issue by telling
git to always resolve these files with `LF` line endings.
fixes #10132
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian commented on pull request #16608: fix: Normalise `*.sh` File Endings
Posted by GitBox <gi...@apache.org>.
suddjian commented on pull request #16608:
URL: https://github.com/apache/superset/pull/16608#issuecomment-918564377
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian merged pull request #16608: fix: Normalise `*.sh` File Endings
Posted by GitBox <gi...@apache.org>.
suddjian merged pull request #16608:
URL: https://github.com/apache/superset/pull/16608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16608: fix: Normalise `*.sh` File Endings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16608:
URL: https://github.com/apache/superset/pull/16608#issuecomment-918644158
@suddjian Ephemeral environment spinning up at http://54.188.58.11:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] gvee-uk commented on pull request #16608: fix: Normalise `*.sh` File Endings
Posted by GitBox <gi...@apache.org>.
gvee-uk commented on pull request #16608:
URL: https://github.com/apache/superset/pull/16608#issuecomment-913658419
I wasn't sure if a `*.sh text eol=lf` would be accepted as it's a broader brush change, hence why I have opted for a more targetted `docker/**/*.sh text eol=lf`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian commented on pull request #16608: fix: Normalise `*.sh` File Endings
Posted by GitBox <gi...@apache.org>.
suddjian commented on pull request #16608:
URL: https://github.com/apache/superset/pull/16608#issuecomment-918643240
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16608: fix: Normalise `*.sh` File Endings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16608:
URL: https://github.com/apache/superset/pull/16608#issuecomment-918658616
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16608: fix: Normalise `*.sh` File Endings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16608:
URL: https://github.com/apache/superset/pull/16608#issuecomment-918565447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org