You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2022/10/26 22:29:33 UTC
[GitHub] [sling-org-apache-sling-commons-mime] agangam opened a new pull request, #5: SLING-11651 - support for multiple mime types for eps
agangam opened a new pull request, #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5
Support multiple mime types to an extension
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-mime] sonarcloud[bot] commented on pull request #5: SLING-11651 - support for multiple mime types for eps
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1295434280
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_coverage&view=list) [91.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-mime] rombert commented on a diff in pull request #5: SLING-11651 - support for multiple mime types for eps
Posted by GitBox <gi...@apache.org>.
rombert commented on code in PR #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1008227094
##########
src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java:
##########
@@ -43,6 +44,18 @@ public class MimeTypeServiceImplTest extends TestCase {
private static final String TEXT_PLAIN = "text/plain";
+ private static final String EPS = "eps";
+
+ private static final Map<String, String> epsMimeTypeExt = new HashMap<>();
+
+ static {
+ epsMimeTypeExt.put("application/eps", EPS);
Review Comment:
I think it's enough to test two different mime types, right? Otherwise we overspecify the behaviour. And for two tests you can use two assertions instead of a map and a loop in the test.
##########
src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java:
##########
@@ -152,6 +165,29 @@ public void testProvider2() throws Exception {
assertNull(this.service.getMimeType(GIF));
}
+ public void testMultipleMimeTypes() throws Exception {
+ loadMimeTypes(MimeTypeServiceImpl.CORE_MIME_TYPES);
+ loadMimeTypes(MimeTypeServiceImpl.MIME_TYPES);
+
+ for (String mm : epsMimeTypeExt.keySet()) {
+ assertEquals("Extension " + mm + " (1)", epsMimeTypeExt.get(mm), this.service.getExtension(mm));
Review Comment:
The name _mm_ is a bit opaque to me, can you please use something to understand?
##########
src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java:
##########
@@ -152,6 +165,29 @@ public void testProvider2() throws Exception {
assertNull(this.service.getMimeType(GIF));
}
+ public void testMultipleMimeTypes() throws Exception {
+ loadMimeTypes(MimeTypeServiceImpl.CORE_MIME_TYPES);
+ loadMimeTypes(MimeTypeServiceImpl.MIME_TYPES);
+
+ for (String mm : epsMimeTypeExt.keySet()) {
+ assertEquals("Extension " + mm + " (1)", epsMimeTypeExt.get(mm), this.service.getExtension(mm));
+ }
+ }
+
+ public void testNegativeTests() throws Exception {
+ loadMimeTypes(MimeTypeServiceImpl.CORE_MIME_TYPES);
+ loadMimeTypes(MimeTypeServiceImpl.MIME_TYPES);
+
+ // null
+ String mm = null;
+ assertEquals("Extension " + mm, mm, this.service.getExtension(mm));
+ this.service.registerMimeType("application/invalid-1", mm);
+ mm = "";
+ assertEquals("Extension " + mm, null, this.service.getExtension(mm));
+ this.service.registerMimeType("application/invalid-1", mm);
Review Comment:
Why are these two registration methods needed? It is unclear what the test is validating, since you have assertions and then apparently an expected exception.
##########
src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java:
##########
@@ -152,6 +165,29 @@ public void testProvider2() throws Exception {
assertNull(this.service.getMimeType(GIF));
}
+ public void testMultipleMimeTypes() throws Exception {
+ loadMimeTypes(MimeTypeServiceImpl.CORE_MIME_TYPES);
+ loadMimeTypes(MimeTypeServiceImpl.MIME_TYPES);
+
+ for (String mm : epsMimeTypeExt.keySet()) {
+ assertEquals("Extension " + mm + " (1)", epsMimeTypeExt.get(mm), this.service.getExtension(mm));
+ }
+ }
+
+ public void testNegativeTests() throws Exception {
+ loadMimeTypes(MimeTypeServiceImpl.CORE_MIME_TYPES);
+ loadMimeTypes(MimeTypeServiceImpl.MIME_TYPES);
+
+ // null
+ String mm = null;
+ assertEquals("Extension " + mm, mm, this.service.getExtension(mm));
Review Comment:
I find it hard to understand what this test does. Perhaps split into multiple methods that each validate a "negative" path?
##########
src/main/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImpl.java:
##########
@@ -166,9 +166,17 @@ public void registerMimeType(String mimeType, String... extensions) {
}
}
+ addToExtensions(defaultExtension, mimeType, extensions);
+ }
+ private void addToExtensions(String defaultExtension, String mimeType, String[] extensions) {
Review Comment:
I think the code would be easier to follow if you cleaned up the extensions array in the `registerMimeType` method ( lowercase, skip null/empty entries ) and no longer had to do so in `addToExtensions`.
I also think it's a good place to use `putIfAbsent` to simplify the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-mime] sonarcloud[bot] commented on pull request #5: SLING-11651 - support for multiple mime types for eps
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1295390488
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-mime] agangam commented on a diff in pull request #5: SLING-11651 - support for multiple mime types for eps
Posted by GitBox <gi...@apache.org>.
agangam commented on code in PR #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1008389902
##########
src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java:
##########
@@ -152,6 +165,29 @@ public void testProvider2() throws Exception {
assertNull(this.service.getMimeType(GIF));
}
+ public void testMultipleMimeTypes() throws Exception {
+ loadMimeTypes(MimeTypeServiceImpl.CORE_MIME_TYPES);
+ loadMimeTypes(MimeTypeServiceImpl.MIME_TYPES);
+
+ for (String mm : epsMimeTypeExt.keySet()) {
+ assertEquals("Extension " + mm + " (1)", epsMimeTypeExt.get(mm), this.service.getExtension(mm));
Review Comment:
agreed, changing it to extension
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-mime] agangam commented on a diff in pull request #5: SLING-11651 - support for multiple mime types for eps
Posted by GitBox <gi...@apache.org>.
agangam commented on code in PR #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1006241408
##########
src/main/resources/META-INF/mime.types:
##########
@@ -24,3 +24,8 @@
application/compress z
image/pict pict
text/plain apt
+# https://en.wikipedia.org/wiki/Encapsulated_PostScript
+application/eps eps
+application/x-eps eps
+image/eps eps
+image/x-eps eps
Review Comment:
Support for missing eps mime types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-mime] agangam commented on a diff in pull request #5: SLING-11651 - support for multiple mime types for eps
Posted by GitBox <gi...@apache.org>.
agangam commented on code in PR #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1008389741
##########
src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java:
##########
@@ -43,6 +44,18 @@ public class MimeTypeServiceImplTest extends TestCase {
private static final String TEXT_PLAIN = "text/plain";
+ private static final String EPS = "eps";
+
+ private static final Map<String, String> epsMimeTypeExt = new HashMap<>();
+
+ static {
+ epsMimeTypeExt.put("application/eps", EPS);
Review Comment:
There are 4 extensions that have been added. I like to test them all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-mime] agangam commented on a diff in pull request #5: SLING-11651 - support for multiple mime types for eps
Posted by GitBox <gi...@apache.org>.
agangam commented on code in PR #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1008388948
##########
src/main/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImpl.java:
##########
@@ -166,9 +166,17 @@ public void registerMimeType(String mimeType, String... extensions) {
}
}
+ addToExtensions(defaultExtension, mimeType, extensions);
+ }
+ private void addToExtensions(String defaultExtension, String mimeType, String[] extensions) {
Review Comment:
Good suggestions, I have simplified the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-mime] agangam commented on a diff in pull request #5: SLING-11651 - support for multiple mime types for eps
Posted by GitBox <gi...@apache.org>.
agangam commented on code in PR #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1008390405
##########
src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java:
##########
@@ -152,6 +165,29 @@ public void testProvider2() throws Exception {
assertNull(this.service.getMimeType(GIF));
}
+ public void testMultipleMimeTypes() throws Exception {
+ loadMimeTypes(MimeTypeServiceImpl.CORE_MIME_TYPES);
+ loadMimeTypes(MimeTypeServiceImpl.MIME_TYPES);
+
+ for (String mm : epsMimeTypeExt.keySet()) {
+ assertEquals("Extension " + mm + " (1)", epsMimeTypeExt.get(mm), this.service.getExtension(mm));
+ }
+ }
+
+ public void testNegativeTests() throws Exception {
+ loadMimeTypes(MimeTypeServiceImpl.CORE_MIME_TYPES);
+ loadMimeTypes(MimeTypeServiceImpl.MIME_TYPES);
+
+ // null
+ String mm = null;
+ assertEquals("Extension " + mm, mm, this.service.getExtension(mm));
Review Comment:
I attempted to simplify them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-mime] agangam commented on a diff in pull request #5: SLING-11651 - support for multiple mime types for eps
Posted by GitBox <gi...@apache.org>.
agangam commented on code in PR #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1006241569
##########
src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java:
##########
@@ -43,6 +44,18 @@ public class MimeTypeServiceImplTest extends TestCase {
private static final String TEXT_PLAIN = "text/plain";
+ private static final String EPS = "eps";
+
+ private static final Map<String, String> epsMimeTypeExt = new HashMap<>();
+
+ static {
+ epsMimeTypeExt.put("application/eps", EPS);
+ epsMimeTypeExt.put("application/x-eps", EPS);
+ epsMimeTypeExt.put("image/eps", EPS);
+ epsMimeTypeExt.put("image/x-eps", EPS);
+ epsMimeTypeExt.put("application/postscript", "ai");
Review Comment:
test all eps mime types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-mime] sonarcloud[bot] commented on pull request #5: SLING-11651 - support for multiple mime types for eps
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1295542361
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_coverage&view=list) [90.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-mime] sonarcloud[bot] commented on pull request #5: SLING-11651 - support for multiple mime types for eps
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1295409026
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_coverage&view=list) [91.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-mime] agangam closed pull request #5: SLING-11651 - support for multiple mime types for eps
Posted by GitBox <gi...@apache.org>.
agangam closed pull request #5: SLING-11651 - support for multiple mime types for eps
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-mime] sonarcloud[bot] commented on pull request #5: SLING-11651 - support for multiple mime types for eps
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1293797976
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_coverage&view=list) [91.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-mime] agangam commented on a diff in pull request #5: SLING-11651 - support for multiple mime types for eps
Posted by GitBox <gi...@apache.org>.
agangam commented on code in PR #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1008390217
##########
src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java:
##########
@@ -152,6 +165,29 @@ public void testProvider2() throws Exception {
assertNull(this.service.getMimeType(GIF));
}
+ public void testMultipleMimeTypes() throws Exception {
+ loadMimeTypes(MimeTypeServiceImpl.CORE_MIME_TYPES);
+ loadMimeTypes(MimeTypeServiceImpl.MIME_TYPES);
+
+ for (String mm : epsMimeTypeExt.keySet()) {
+ assertEquals("Extension " + mm + " (1)", epsMimeTypeExt.get(mm), this.service.getExtension(mm));
+ }
+ }
+
+ public void testNegativeTests() throws Exception {
+ loadMimeTypes(MimeTypeServiceImpl.CORE_MIME_TYPES);
+ loadMimeTypes(MimeTypeServiceImpl.MIME_TYPES);
+
+ // null
+ String mm = null;
+ assertEquals("Extension " + mm, mm, this.service.getExtension(mm));
+ this.service.registerMimeType("application/invalid-1", mm);
+ mm = "";
+ assertEquals("Extension " + mm, null, this.service.getExtension(mm));
+ this.service.registerMimeType("application/invalid-1", mm);
Review Comment:
They are negative tests with invalid values registered. Simplified the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-mime] sonarcloud[bot] commented on pull request #5: SLING-11651 - support for multiple mime types for eps
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1292736472
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_coverage&view=list) [70.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-mime] agangam commented on pull request #5: SLING-11651 - support for multiple mime types for eps
Posted by GitBox <gi...@apache.org>.
agangam commented on PR #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1293814344
> Thanks for the contribution @agangam . Can you please resubmit a version without formatting/whitespace changes?
Reverted the formatting changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-mime] sonarcloud[bot] commented on pull request #5: SLING-11651 - support for multiple mime types for eps
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1292760237
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_coverage&view=list) [69.6% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-mime] sonarcloud[bot] commented on pull request #5: SLING-11651 - support for multiple mime types for eps
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1295379553
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-mime] sonarcloud[bot] commented on pull request #5: SLING-11651 - support for multiple mime types for eps
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5:
URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1292754655
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_coverage&view=list) [70.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-mime&pullRequest=5&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org