You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/03/16 14:21:54 UTC
Review Request 32101: LENS-405 : Add cache for latest partition in
dimtable's storage tables
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32101/
-----------------------------------------------------------
Review request for lens, Jaideep dhok and Rajat Khandelwal.
Bugs: LENS-405
https://issues.apache.org/jira/browse/LENS-405
Repository: lens
Description
-------
- Adds simple storage table name cache for which latest partitions exists.
- Cache is initialized on first call to getDimensionTable
- Updated with add and drop partitions
- Updated TestCubeMetastoreClient to assert the cache value
- Fixed CubeTestSetup - city was not getting created with correct dump periods
- Fixed TestMetastoreService to alwasys create Dimension corresponding to DimTable
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 10e8ec0
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java be1261e
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e9
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java cdf3da6
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 1c63861
Diff: https://reviews.apache.org/r/32101/diff/
Testing
-------
Still seeing some failures on CLI tests. Will update once all tests pass.
Thanks,
Amareshwari Sriramadasu
Re: Review Request 32101: LENS-405 : Add cache for latest partition in
dimtable's storage tables
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32101/
-----------------------------------------------------------
(Updated March 19, 2015, 12:43 p.m.)
Review request for lens, Jaideep dhok and Rajat Khandelwal.
Changes
-------
Missed test failure changes after merge in earlier patch.
Bugs: LENS-405
https://issues.apache.org/jira/browse/LENS-405
Repository: lens
Description
-------
- Adds simple storage table name cache for which latest partitions exists.
- Cache is initialized on first call to getDimensionTable
- Updated with add and drop partitions
- Updated TestCubeMetastoreClient to assert the cache value
- Fixed CubeTestSetup - city was not getting created with correct dump periods
- Fixed TestMetastoreService to alwasys create Dimension corresponding to DimTable
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 4ed1163
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java d3647f1
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 2029829
lens-cli/src/test/resources/data.data 6c99c9a
lens-cli/src/test/resources/dim2-part/data.data PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java 4bee3b7
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 151fe98
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java bcda79a
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java be1261e
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 5a86f60
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java cdf3da6
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 1c63861
Diff: https://reviews.apache.org/r/32101/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.144s]
[INFO] Lens .............................................. SUCCESS [1.652s]
[INFO] Lens API .......................................... SUCCESS [4.903s]
[INFO] Lens API for server and extensions ................ SUCCESS [7.138s]
[INFO] Lens Cube ......................................... SUCCESS [2:02.498s]
[INFO] Lens DB storage ................................... SUCCESS [10.451s]
[INFO] Lens Query Library ................................ SUCCESS [4.448s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:37.351s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [17.584s]
[INFO] Lens Server ....................................... SUCCESS [4:12.845s]
[INFO] Lens client ....................................... SUCCESS [21.281s]
[INFO] Lens CLI .......................................... SUCCESS [2:41.742s]
[INFO] Lens Examples ..................................... SUCCESS [0.788s]
[INFO] Lens Distribution ................................. SUCCESS [9.290s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.272s]
[INFO] Lens Regression ................................... SUCCESS [0.491s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:37.829s
[INFO] Finished at: Thu Mar 19 12:31:15 UTC 2015
[INFO] Final Memory: 109M/1236M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 32101: LENS-405 : Add cache for latest partition in
dimtable's storage tables
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32101/
-----------------------------------------------------------
(Updated March 19, 2015, 12:38 p.m.)
Review request for lens, Jaideep dhok and Rajat Khandelwal.
Changes
-------
Updated to master
Bugs: LENS-405
https://issues.apache.org/jira/browse/LENS-405
Repository: lens
Description
-------
- Adds simple storage table name cache for which latest partitions exists.
- Cache is initialized on first call to getDimensionTable
- Updated with add and drop partitions
- Updated TestCubeMetastoreClient to assert the cache value
- Fixed CubeTestSetup - city was not getting created with correct dump periods
- Fixed TestMetastoreService to alwasys create Dimension corresponding to DimTable
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 4ed1163
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java d3647f1
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 2029829
lens-cli/src/test/resources/data.data 6c99c9a
lens-cli/src/test/resources/dim2-part/data.data PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java 4bee3b7
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 151fe98
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java bcda79a
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java be1261e
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 5a86f60
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java cdf3da6
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 1c63861
Diff: https://reviews.apache.org/r/32101/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.144s]
[INFO] Lens .............................................. SUCCESS [1.652s]
[INFO] Lens API .......................................... SUCCESS [4.903s]
[INFO] Lens API for server and extensions ................ SUCCESS [7.138s]
[INFO] Lens Cube ......................................... SUCCESS [2:02.498s]
[INFO] Lens DB storage ................................... SUCCESS [10.451s]
[INFO] Lens Query Library ................................ SUCCESS [4.448s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:37.351s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [17.584s]
[INFO] Lens Server ....................................... SUCCESS [4:12.845s]
[INFO] Lens client ....................................... SUCCESS [21.281s]
[INFO] Lens CLI .......................................... SUCCESS [2:41.742s]
[INFO] Lens Examples ..................................... SUCCESS [0.788s]
[INFO] Lens Distribution ................................. SUCCESS [9.290s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.272s]
[INFO] Lens Regression ................................... SUCCESS [0.491s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:37.829s
[INFO] Finished at: Thu Mar 19 12:31:15 UTC 2015
[INFO] Final Memory: 109M/1236M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 32101: LENS-405 : Add cache for latest partition in
dimtable's storage tables
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32101/#review77036
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On March 19, 2015, 11:19 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32101/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 11:19 a.m.)
>
>
> Review request for lens, Jaideep dhok and Rajat Khandelwal.
>
>
> Bugs: LENS-405
> https://issues.apache.org/jira/browse/LENS-405
>
>
> Repository: lens
>
>
> Description
> -------
>
> - Adds simple storage table name cache for which latest partitions exists.
> - Cache is initialized on first call to getDimensionTable
> - Updated with add and drop partitions
> - Updated TestCubeMetastoreClient to assert the cache value
> - Fixed CubeTestSetup - city was not getting created with correct dump periods
> - Fixed TestMetastoreService to alwasys create Dimension corresponding to DimTable
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 4ed1163
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java d3647f1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 2029829
> lens-cli/src/test/resources/data.data 6c99c9a
> lens-cli/src/test/resources/dim2-part/data.data PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 4bee3b7
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b0d2e63
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java be1261e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e9
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java cdf3da6
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 1c63861
>
> Diff: https://reviews.apache.org/r/32101/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.882s]
> [INFO] Lens .............................................. SUCCESS [2.321s]
> [INFO] Lens API .......................................... SUCCESS [7.525s]
> [INFO] Lens API for server and extensions ................ SUCCESS [9.422s]
> [INFO] Lens Cube ......................................... SUCCESS [2:10.723s]
> [INFO] Lens DB storage ................................... SUCCESS [10.385s]
> [INFO] Lens Query Library ................................ SUCCESS [4.254s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.093s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.394s]
> [INFO] Lens Server ....................................... SUCCESS [4:14.897s]
> [INFO] Lens client ....................................... SUCCESS [20.816s]
> [INFO] Lens CLI .......................................... SUCCESS [1:22.529s]
> [INFO] Lens Examples ..................................... SUCCESS [0.839s]
> [INFO] Lens Distribution ................................. SUCCESS [9.487s]
> [INFO] Lens ML Lib ....................................... SUCCESS [42.318s]
> [INFO] Lens Regression ................................... SUCCESS [0.479s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:34.412s
> [INFO] Finished at: Tue Mar 17 06:47:49 UTC 2015
> [INFO] Final Memory: 110M/1143M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 32101: LENS-405 : Add cache for latest partition in
dimtable's storage tables
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32101/
-----------------------------------------------------------
(Updated March 19, 2015, 5:49 a.m.)
Review request for lens, Jaideep dhok and Rajat Khandelwal.
Changes
-------
Review comments addressed
Bugs: LENS-405
https://issues.apache.org/jira/browse/LENS-405
Repository: lens
Description
-------
- Adds simple storage table name cache for which latest partitions exists.
- Cache is initialized on first call to getDimensionTable
- Updated with add and drop partitions
- Updated TestCubeMetastoreClient to assert the cache value
- Fixed CubeTestSetup - city was not getting created with correct dump periods
- Fixed TestMetastoreService to alwasys create Dimension corresponding to DimTable
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 4ed1163
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java d3647f1
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 2029829
lens-cli/src/test/resources/data.data 6c99c9a
lens-cli/src/test/resources/dim2-part/data.data PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java 4bee3b7
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b0d2e63
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java be1261e
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e9
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java cdf3da6
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 1c63861
Diff: https://reviews.apache.org/r/32101/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.882s]
[INFO] Lens .............................................. SUCCESS [2.321s]
[INFO] Lens API .......................................... SUCCESS [7.525s]
[INFO] Lens API for server and extensions ................ SUCCESS [9.422s]
[INFO] Lens Cube ......................................... SUCCESS [2:10.723s]
[INFO] Lens DB storage ................................... SUCCESS [10.385s]
[INFO] Lens Query Library ................................ SUCCESS [4.254s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:37.093s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [17.394s]
[INFO] Lens Server ....................................... SUCCESS [4:14.897s]
[INFO] Lens client ....................................... SUCCESS [20.816s]
[INFO] Lens CLI .......................................... SUCCESS [1:22.529s]
[INFO] Lens Examples ..................................... SUCCESS [0.839s]
[INFO] Lens Distribution ................................. SUCCESS [9.487s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.318s]
[INFO] Lens Regression ................................... SUCCESS [0.479s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12:34.412s
[INFO] Finished at: Tue Mar 17 06:47:49 UTC 2015
[INFO] Final Memory: 110M/1143M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 32101: LENS-405 : Add cache for latest partition in
dimtable's storage tables
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On March 18, 2015, 9:55 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, line 988
> > <https://reviews.apache.org/r/32101/diff/2/?file=897606#file897606line988>
> >
> > Should we think about the case where a dimension has multiple time partitions
The only timedimension allowed for dimension tables is dumping at a snapshot interval and users will be able to query latest dump. Though current code allows multiple timedimensions for a storage table, it does not make sense to have multple timedimensions exposed at DimensionTable. Not changing this functionality
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32101/#review76887
-----------------------------------------------------------
On March 19, 2015, 5:49 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32101/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 5:49 a.m.)
>
>
> Review request for lens, Jaideep dhok and Rajat Khandelwal.
>
>
> Bugs: LENS-405
> https://issues.apache.org/jira/browse/LENS-405
>
>
> Repository: lens
>
>
> Description
> -------
>
> - Adds simple storage table name cache for which latest partitions exists.
> - Cache is initialized on first call to getDimensionTable
> - Updated with add and drop partitions
> - Updated TestCubeMetastoreClient to assert the cache value
> - Fixed CubeTestSetup - city was not getting created with correct dump periods
> - Fixed TestMetastoreService to alwasys create Dimension corresponding to DimTable
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 4ed1163
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java d3647f1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 2029829
> lens-cli/src/test/resources/data.data 6c99c9a
> lens-cli/src/test/resources/dim2-part/data.data PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 4bee3b7
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b0d2e63
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java be1261e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e9
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java cdf3da6
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 1c63861
>
> Diff: https://reviews.apache.org/r/32101/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.882s]
> [INFO] Lens .............................................. SUCCESS [2.321s]
> [INFO] Lens API .......................................... SUCCESS [7.525s]
> [INFO] Lens API for server and extensions ................ SUCCESS [9.422s]
> [INFO] Lens Cube ......................................... SUCCESS [2:10.723s]
> [INFO] Lens DB storage ................................... SUCCESS [10.385s]
> [INFO] Lens Query Library ................................ SUCCESS [4.254s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.093s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.394s]
> [INFO] Lens Server ....................................... SUCCESS [4:14.897s]
> [INFO] Lens client ....................................... SUCCESS [20.816s]
> [INFO] Lens CLI .......................................... SUCCESS [1:22.529s]
> [INFO] Lens Examples ..................................... SUCCESS [0.839s]
> [INFO] Lens Distribution ................................. SUCCESS [9.487s]
> [INFO] Lens ML Lib ....................................... SUCCESS [42.318s]
> [INFO] Lens Regression ................................... SUCCESS [0.479s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:34.412s
> [INFO] Finished at: Tue Mar 17 06:47:49 UTC 2015
> [INFO] Final Memory: 110M/1143M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 32101: LENS-405 : Add cache for latest partition in
dimtable's storage tables
Posted by Amareshwari Sriramadasu <am...@apache.org>.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32101/#review76887
-----------------------------------------------------------
On March 19, 2015, 5:49 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32101/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 5:49 a.m.)
>
>
> Review request for lens, Jaideep dhok and Rajat Khandelwal.
>
>
> Bugs: LENS-405
> https://issues.apache.org/jira/browse/LENS-405
>
>
> Repository: lens
>
>
> Description
> -------
>
> - Adds simple storage table name cache for which latest partitions exists.
> - Cache is initialized on first call to getDimensionTable
> - Updated with add and drop partitions
> - Updated TestCubeMetastoreClient to assert the cache value
> - Fixed CubeTestSetup - city was not getting created with correct dump periods
> - Fixed TestMetastoreService to alwasys create Dimension corresponding to DimTable
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 4ed1163
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java d3647f1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 2029829
> lens-cli/src/test/resources/data.data 6c99c9a
> lens-cli/src/test/resources/dim2-part/data.data PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 4bee3b7
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b0d2e63
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java be1261e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e9
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java cdf3da6
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 1c63861
>
> Diff: https://reviews.apache.org/r/32101/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.882s]
> [INFO] Lens .............................................. SUCCESS [2.321s]
> [INFO] Lens API .......................................... SUCCESS [7.525s]
> [INFO] Lens API for server and extensions ................ SUCCESS [9.422s]
> [INFO] Lens Cube ......................................... SUCCESS [2:10.723s]
> [INFO] Lens DB storage ................................... SUCCESS [10.385s]
> [INFO] Lens Query Library ................................ SUCCESS [4.254s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.093s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.394s]
> [INFO] Lens Server ....................................... SUCCESS [4:14.897s]
> [INFO] Lens client ....................................... SUCCESS [20.816s]
> [INFO] Lens CLI .......................................... SUCCESS [1:22.529s]
> [INFO] Lens Examples ..................................... SUCCESS [0.839s]
> [INFO] Lens Distribution ................................. SUCCESS [9.487s]
> [INFO] Lens ML Lib ....................................... SUCCESS [42.318s]
> [INFO] Lens Regression ................................... SUCCESS [0.479s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:34.412s
> [INFO] Finished at: Tue Mar 17 06:47:49 UTC 2015
> [INFO] Final Memory: 110M/1143M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 32101: LENS-405 : Add cache for latest partition in
dimtable's storage tables
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32101/#review76887
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
<https://reviews.apache.org/r/32101/#comment124586>
Should we think about the case where a dimension has multiple time partitions
- Rajat Khandelwal
On March 17, 2015, 12:28 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32101/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 12:28 p.m.)
>
>
> Review request for lens, Jaideep dhok and Rajat Khandelwal.
>
>
> Bugs: LENS-405
> https://issues.apache.org/jira/browse/LENS-405
>
>
> Repository: lens
>
>
> Description
> -------
>
> - Adds simple storage table name cache for which latest partitions exists.
> - Cache is initialized on first call to getDimensionTable
> - Updated with add and drop partitions
> - Updated TestCubeMetastoreClient to assert the cache value
> - Fixed CubeTestSetup - city was not getting created with correct dump periods
> - Fixed TestMetastoreService to alwasys create Dimension corresponding to DimTable
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 4ed1163
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java d3647f1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 73d53f6
> lens-cli/src/test/resources/data.data 6c99c9a
> lens-cli/src/test/resources/dim2-part/data.data PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 4bee3b7
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 10e8ec0
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java be1261e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e9
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java cdf3da6
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 1c63861
>
> Diff: https://reviews.apache.org/r/32101/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.882s]
> [INFO] Lens .............................................. SUCCESS [2.321s]
> [INFO] Lens API .......................................... SUCCESS [7.525s]
> [INFO] Lens API for server and extensions ................ SUCCESS [9.422s]
> [INFO] Lens Cube ......................................... SUCCESS [2:10.723s]
> [INFO] Lens DB storage ................................... SUCCESS [10.385s]
> [INFO] Lens Query Library ................................ SUCCESS [4.254s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.093s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.394s]
> [INFO] Lens Server ....................................... SUCCESS [4:14.897s]
> [INFO] Lens client ....................................... SUCCESS [20.816s]
> [INFO] Lens CLI .......................................... SUCCESS [1:22.529s]
> [INFO] Lens Examples ..................................... SUCCESS [0.839s]
> [INFO] Lens Distribution ................................. SUCCESS [9.487s]
> [INFO] Lens ML Lib ....................................... SUCCESS [42.318s]
> [INFO] Lens Regression ................................... SUCCESS [0.479s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:34.412s
> [INFO] Finished at: Tue Mar 17 06:47:49 UTC 2015
> [INFO] Final Memory: 110M/1143M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 32101: LENS-405 : Add cache for latest partition in
dimtable's storage tables
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On March 17, 2015, 9:25 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java, line 1351
> > <https://reviews.apache.org/r/32101/diff/2/?file=897609#file897609line1351>
> >
> > Why null?
null value for dumpPeriod means the table is not snapshotted/dumped and is available as direct table in the underlying storage
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32101/#review76720
-----------------------------------------------------------
On March 19, 2015, 5:49 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32101/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 5:49 a.m.)
>
>
> Review request for lens, Jaideep dhok and Rajat Khandelwal.
>
>
> Bugs: LENS-405
> https://issues.apache.org/jira/browse/LENS-405
>
>
> Repository: lens
>
>
> Description
> -------
>
> - Adds simple storage table name cache for which latest partitions exists.
> - Cache is initialized on first call to getDimensionTable
> - Updated with add and drop partitions
> - Updated TestCubeMetastoreClient to assert the cache value
> - Fixed CubeTestSetup - city was not getting created with correct dump periods
> - Fixed TestMetastoreService to alwasys create Dimension corresponding to DimTable
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 4ed1163
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java d3647f1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 2029829
> lens-cli/src/test/resources/data.data 6c99c9a
> lens-cli/src/test/resources/dim2-part/data.data PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 4bee3b7
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b0d2e63
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java be1261e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e9
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java cdf3da6
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 1c63861
>
> Diff: https://reviews.apache.org/r/32101/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.882s]
> [INFO] Lens .............................................. SUCCESS [2.321s]
> [INFO] Lens API .......................................... SUCCESS [7.525s]
> [INFO] Lens API for server and extensions ................ SUCCESS [9.422s]
> [INFO] Lens Cube ......................................... SUCCESS [2:10.723s]
> [INFO] Lens DB storage ................................... SUCCESS [10.385s]
> [INFO] Lens Query Library ................................ SUCCESS [4.254s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.093s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.394s]
> [INFO] Lens Server ....................................... SUCCESS [4:14.897s]
> [INFO] Lens client ....................................... SUCCESS [20.816s]
> [INFO] Lens CLI .......................................... SUCCESS [1:22.529s]
> [INFO] Lens Examples ..................................... SUCCESS [0.839s]
> [INFO] Lens Distribution ................................. SUCCESS [9.487s]
> [INFO] Lens ML Lib ....................................... SUCCESS [42.318s]
> [INFO] Lens Regression ................................... SUCCESS [0.479s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:34.412s
> [INFO] Finished at: Tue Mar 17 06:47:49 UTC 2015
> [INFO] Final Memory: 110M/1143M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 32101: LENS-405 : Add cache for latest partition in
dimtable's storage tables
Posted by Amareshwari Sriramadasu <am...@apache.org>.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32101/#review76720
-----------------------------------------------------------
On March 19, 2015, 5:49 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32101/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 5:49 a.m.)
>
>
> Review request for lens, Jaideep dhok and Rajat Khandelwal.
>
>
> Bugs: LENS-405
> https://issues.apache.org/jira/browse/LENS-405
>
>
> Repository: lens
>
>
> Description
> -------
>
> - Adds simple storage table name cache for which latest partitions exists.
> - Cache is initialized on first call to getDimensionTable
> - Updated with add and drop partitions
> - Updated TestCubeMetastoreClient to assert the cache value
> - Fixed CubeTestSetup - city was not getting created with correct dump periods
> - Fixed TestMetastoreService to alwasys create Dimension corresponding to DimTable
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 4ed1163
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java d3647f1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 2029829
> lens-cli/src/test/resources/data.data 6c99c9a
> lens-cli/src/test/resources/dim2-part/data.data PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 4bee3b7
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b0d2e63
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java be1261e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e9
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java cdf3da6
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 1c63861
>
> Diff: https://reviews.apache.org/r/32101/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.882s]
> [INFO] Lens .............................................. SUCCESS [2.321s]
> [INFO] Lens API .......................................... SUCCESS [7.525s]
> [INFO] Lens API for server and extensions ................ SUCCESS [9.422s]
> [INFO] Lens Cube ......................................... SUCCESS [2:10.723s]
> [INFO] Lens DB storage ................................... SUCCESS [10.385s]
> [INFO] Lens Query Library ................................ SUCCESS [4.254s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.093s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.394s]
> [INFO] Lens Server ....................................... SUCCESS [4:14.897s]
> [INFO] Lens client ....................................... SUCCESS [20.816s]
> [INFO] Lens CLI .......................................... SUCCESS [1:22.529s]
> [INFO] Lens Examples ..................................... SUCCESS [0.839s]
> [INFO] Lens Distribution ................................. SUCCESS [9.487s]
> [INFO] Lens ML Lib ....................................... SUCCESS [42.318s]
> [INFO] Lens Regression ................................... SUCCESS [0.479s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:34.412s
> [INFO] Finished at: Tue Mar 17 06:47:49 UTC 2015
> [INFO] Final Memory: 110M/1143M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 32101: LENS-405 : Add cache for latest partition in
dimtable's storage tables
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32101/#review76720
-----------------------------------------------------------
lens-client/src/main/java/org/apache/lens/client/LensClient.java
<https://reviews.apache.org/r/32101/#comment124348>
Corresponding methods for adding `XPartitionList` and two functions for adding to fact as well
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java
<https://reviews.apache.org/r/32101/#comment124349>
Why null?
- Rajat Khandelwal
On March 17, 2015, 12:28 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32101/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 12:28 p.m.)
>
>
> Review request for lens, Jaideep dhok and Rajat Khandelwal.
>
>
> Bugs: LENS-405
> https://issues.apache.org/jira/browse/LENS-405
>
>
> Repository: lens
>
>
> Description
> -------
>
> - Adds simple storage table name cache for which latest partitions exists.
> - Cache is initialized on first call to getDimensionTable
> - Updated with add and drop partitions
> - Updated TestCubeMetastoreClient to assert the cache value
> - Fixed CubeTestSetup - city was not getting created with correct dump periods
> - Fixed TestMetastoreService to alwasys create Dimension corresponding to DimTable
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 4ed1163
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java d3647f1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 73d53f6
> lens-cli/src/test/resources/data.data 6c99c9a
> lens-cli/src/test/resources/dim2-part/data.data PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 4bee3b7
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 10e8ec0
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java be1261e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e9
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java cdf3da6
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 1c63861
>
> Diff: https://reviews.apache.org/r/32101/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.882s]
> [INFO] Lens .............................................. SUCCESS [2.321s]
> [INFO] Lens API .......................................... SUCCESS [7.525s]
> [INFO] Lens API for server and extensions ................ SUCCESS [9.422s]
> [INFO] Lens Cube ......................................... SUCCESS [2:10.723s]
> [INFO] Lens DB storage ................................... SUCCESS [10.385s]
> [INFO] Lens Query Library ................................ SUCCESS [4.254s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.093s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.394s]
> [INFO] Lens Server ....................................... SUCCESS [4:14.897s]
> [INFO] Lens client ....................................... SUCCESS [20.816s]
> [INFO] Lens CLI .......................................... SUCCESS [1:22.529s]
> [INFO] Lens Examples ..................................... SUCCESS [0.839s]
> [INFO] Lens Distribution ................................. SUCCESS [9.487s]
> [INFO] Lens ML Lib ....................................... SUCCESS [42.318s]
> [INFO] Lens Regression ................................... SUCCESS [0.479s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:34.412s
> [INFO] Finished at: Tue Mar 17 06:47:49 UTC 2015
> [INFO] Final Memory: 110M/1143M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 32101: LENS-405 : Add cache for latest partition in
dimtable's storage tables
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32101/
-----------------------------------------------------------
(Updated March 17, 2015, 6:58 a.m.)
Review request for lens, Jaideep dhok and Rajat Khandelwal.
Changes
-------
Fixed CLI test setup issues
Bugs: LENS-405
https://issues.apache.org/jira/browse/LENS-405
Repository: lens
Description
-------
- Adds simple storage table name cache for which latest partitions exists.
- Cache is initialized on first call to getDimensionTable
- Updated with add and drop partitions
- Updated TestCubeMetastoreClient to assert the cache value
- Fixed CubeTestSetup - city was not getting created with correct dump periods
- Fixed TestMetastoreService to alwasys create Dimension corresponding to DimTable
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 4ed1163
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java d3647f1
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 73d53f6
lens-cli/src/test/resources/data.data 6c99c9a
lens-cli/src/test/resources/dim2-part/data.data PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java 4bee3b7
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 10e8ec0
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java be1261e
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e9
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java cdf3da6
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 1c63861
Diff: https://reviews.apache.org/r/32101/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.882s]
[INFO] Lens .............................................. SUCCESS [2.321s]
[INFO] Lens API .......................................... SUCCESS [7.525s]
[INFO] Lens API for server and extensions ................ SUCCESS [9.422s]
[INFO] Lens Cube ......................................... SUCCESS [2:10.723s]
[INFO] Lens DB storage ................................... SUCCESS [10.385s]
[INFO] Lens Query Library ................................ SUCCESS [4.254s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:37.093s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [17.394s]
[INFO] Lens Server ....................................... SUCCESS [4:14.897s]
[INFO] Lens client ....................................... SUCCESS [20.816s]
[INFO] Lens CLI .......................................... SUCCESS [1:22.529s]
[INFO] Lens Examples ..................................... SUCCESS [0.839s]
[INFO] Lens Distribution ................................. SUCCESS [9.487s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.318s]
[INFO] Lens Regression ................................... SUCCESS [0.479s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12:34.412s
[INFO] Finished at: Tue Mar 17 06:47:49 UTC 2015
[INFO] Final Memory: 110M/1143M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu