You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "swebb2066 (via GitHub)" <gi...@apache.org> on 2026/10/20 02:19:08 UTC

[PR] Remove unnecessary and unimplemented interface methods [logging-log4cxx]

swebb2066 opened a new pull request, #786:
URL: https://github.com/apache/logging-log4cxx/pull/786

   This PR reduces the ABI footprint by utilising default values to avoid duplication.
   
   Also, removes `Logger::getLogger(name, factory)` methods for which an implementation was never provided.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove unnecessary and unimplemented interface methods [logging-log4cxx]

Posted by "swebb2066 (via GitHub)" <gi...@apache.org>.
swebb2066 merged PR #786:
URL: https://github.com/apache/logging-log4cxx/pull/786


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove unnecessary and unimplemented interface methods [logging-log4cxx]

Posted by "rm5248 (via GitHub)" <gi...@apache.org>.
rm5248 commented on code in PR #786:
URL: https://github.com/apache/logging-log4cxx/pull/786#discussion_r4324558017


##########
src/main/include/log4cxx/logmanager.h:
##########
@@ -75,16 +75,6 @@ class LOG4CXX_EXPORT LogManager
 		*/
 		static LoggerPtr getRootLogger();
 
-		/**
-		Retrieve the \c name Logger instance from the
-		{@link spi::LoggerRepository LoggerRepository}
-		using the default factory to create it if required.
-
-		Calls {@link spi::LoggerRepository::ensureIsConfigured ensureIsConfigured} passing {@link DefaultConfigurator::configure} to ensure
-		the repository is configured.
-		*/
-		static LoggerPtr getLogger(const std::string& name);

Review Comment:
   I know that I've written code before that uses `LogManager::getLogger()` since it is equivalent to `Logger::getLogger()` - adding an explicit entry to the changelog stating the removal(and how to fix) would be good here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove unnecessary and unimplemented interface methods [logging-log4cxx]

Posted by "swebb2066 (via GitHub)" <gi...@apache.org>.
swebb2066 commented on code in PR #786:
URL: https://github.com/apache/logging-log4cxx/pull/786#discussion_r4332086727


##########
src/main/include/log4cxx/logmanager.h:
##########
@@ -75,16 +75,6 @@ class LOG4CXX_EXPORT LogManager
 		*/
 		static LoggerPtr getRootLogger();
 
-		/**
-		Retrieve the \c name Logger instance from the
-		{@link spi::LoggerRepository LoggerRepository}
-		using the default factory to create it if required.
-
-		Calls {@link spi::LoggerRepository::ensureIsConfigured ensureIsConfigured} passing {@link DefaultConfigurator::configure} to ensure
-		the repository is configured.
-		*/
-		static LoggerPtr getLogger(const std::string& name);

Review Comment:
   > I've written code before that uses LogManager::getLogger()
   
   That code will continue to compile without any change. The compiler with silently add the default value for `spi::LoggerFactoryPtr` and call the two parameter version of LogManager::getLogger().



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org