You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Gautam Borad <gb...@gmail.com> on 2015/02/02 12:52:02 UTC

Review Request 30492: Ranger service should tell it's Software verison

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30492/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-210
    https://issues.apache.org/jira/browse/RANGER-210


Repository: ranger


Description
-------

Add ranger-admin and ranger-usersync that will be used to provide : start | stop | restart | version


Diffs
-----

  embeddedwebserver/scripts/ranger-admin b1ef4f5 
  embeddedwebserver/scripts/ranger-admin-services.sh PRE-CREATION 
  embeddedwebserver/scripts/start-ranger-admin.sh 19df2aa 
  embeddedwebserver/scripts/stop-ranger-admin.sh c6c4bf6 
  pom.xml cba652e 
  ranger-util/.gitignore PRE-CREATION 
  ranger-util/pom.xml PRE-CREATION 
  ranger-util/src/gen/org/apache/ranger/common/package-info.java PRE-CREATION 
  ranger-util/src/main/java/org/apache/ranger/common/RangerVersionAnnotation.java PRE-CREATION 
  ranger-util/src/main/java/org/apache/ranger/common/RangerVersionInfo.java PRE-CREATION 
  ranger-util/src/scripts/saveVersion.sh PRE-CREATION 
  security-admin/pom.xml 32d15d3 
  security-admin/scripts/setup.sh bc241e2 
  src/main/assembly/usersync.xml 0adb0a3 
  ugsync/pom.xml 93b812e 
  unixauthservice/scripts/initd e429cce 
  unixauthservice/scripts/ranger-usersync-services.sh PRE-CREATION 
  unixauthservice/scripts/setup.sh 5afb199 
  unixauthservice/scripts/start.sh 399e6b2 
  unixauthservice/scripts/stop.sh 1933364 

Diff: https://reviews.apache.org/r/30492/diff/


Testing
-------

Built tar by applying patch and tested the following on CentOS 6.5 :

1] Install ranger-admin
2] run : 'ranger-admin start' and check that ranger admin is running
3] run : 'ranger-admin stop' and check that ranger admin is stopped
4] run : '/etc/init.d/ranger-admin start' and check that ranger admin is running
5] run : '/etc/init.d/ranger-admin stop' and check that ranger admin is stopped

6] run : 'ranger-admin version' and check the version is printed

------------------------------------------------------------------------------------

1] Install ranger-usersync
2] run : 'ranger-usersync start' and check that ranger usersync is running
3] run : 'ranger-usersync stop' and check that ranger usersync is stopped
4] run : '/etc/init.d/ranger-usersync start' and check that ranger usersync is running
5] run : '/etc/init.d/ranger-usersync stop' and check that ranger usersync is stopped

6] run : 'ranger-usersync version' and check the version is printed

------------------------------------------------------------------------------------

Please note the following open issues:

1] The linking of /usr/bin/ranger-admin to $INSTALL_DIR/ews/ranger-admin-services.sh is now done as a part of installation process.

2] Running /etc/init.d/ranger-admin start as root is notsupported currently.


Thanks,

Gautam Borad


Re: Review Request 30492: Ranger service should tell it's Software verison

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30492/#review75180
-----------------------------------------------------------

Ship it!


Ship It!

- Velmurugan Periasamy


On March 4, 2015, 9:02 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30492/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 9:02 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-210
>     https://issues.apache.org/jira/browse/RANGER-210
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Add ranger-admin and ranger-usersync that will be used to provide : start | stop | restart | version
> 
> 
> Diffs
> -----
> 
>   embeddedwebserver/scripts/ranger-admin f916dbb 
>   security-admin/scripts/setup.sh beb1a55 
> 
> Diff: https://reviews.apache.org/r/30492/diff/
> 
> 
> Testing
> -------
> 
> Built tar by applying patch and tested the following on CentOS 6.5 :
> 
> 1] Install ranger-admin
> 2] run : 'ranger-admin start' and check that ranger admin is running
> 3] run : 'ranger-admin stop' and check that ranger admin is stopped
> 4] run : '/etc/init.d/ranger-admin start' and check that ranger admin is running
> 5] run : '/etc/init.d/ranger-admin stop' and check that ranger admin is stopped
> 
> 6] run : 'ranger-admin version' and check the version is printed
> 
> ------------------------------------------------------------------------------------
> 
> 1] Install ranger-usersync
> 2] run : 'ranger-usersync start' and check that ranger usersync is running
> 3] run : 'ranger-usersync stop' and check that ranger usersync is stopped
> 4] run : '/etc/init.d/ranger-usersync start' and check that ranger usersync is running
> 5] run : '/etc/init.d/ranger-usersync stop' and check that ranger usersync is stopped
> 
> 6] run : 'ranger-usersync version' and check the version is printed
> 
> ------------------------------------------------------------------------------------
> 
> Please note the following open issues:
> 
> 1] The linking of /usr/bin/ranger-admin to $INSTALL_DIR/ews/ranger-admin-services.sh is now done as a part of installation process.
> 
> 2] Running /etc/init.d/ranger-admin start as root is notsupported currently.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 30492: Ranger service should tell it's Software verison

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30492/
-----------------------------------------------------------

(Updated March 4, 2015, 9:02 a.m.)


Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Changes
-------

Updated diff to be a patch file


Bugs: RANGER-210
    https://issues.apache.org/jira/browse/RANGER-210


Repository: ranger


Description
-------

Add ranger-admin and ranger-usersync that will be used to provide : start | stop | restart | version


Diffs (updated)
-----

  embeddedwebserver/scripts/ranger-admin f916dbb 
  security-admin/scripts/setup.sh beb1a55 

Diff: https://reviews.apache.org/r/30492/diff/


Testing
-------

Built tar by applying patch and tested the following on CentOS 6.5 :

1] Install ranger-admin
2] run : 'ranger-admin start' and check that ranger admin is running
3] run : 'ranger-admin stop' and check that ranger admin is stopped
4] run : '/etc/init.d/ranger-admin start' and check that ranger admin is running
5] run : '/etc/init.d/ranger-admin stop' and check that ranger admin is stopped

6] run : 'ranger-admin version' and check the version is printed

------------------------------------------------------------------------------------

1] Install ranger-usersync
2] run : 'ranger-usersync start' and check that ranger usersync is running
3] run : 'ranger-usersync stop' and check that ranger usersync is stopped
4] run : '/etc/init.d/ranger-usersync start' and check that ranger usersync is running
5] run : '/etc/init.d/ranger-usersync stop' and check that ranger usersync is stopped

6] run : 'ranger-usersync version' and check the version is printed

------------------------------------------------------------------------------------

Please note the following open issues:

1] The linking of /usr/bin/ranger-admin to $INSTALL_DIR/ews/ranger-admin-services.sh is now done as a part of installation process.

2] Running /etc/init.d/ranger-admin start as root is notsupported currently.


Thanks,

Gautam Borad


Re: Review Request 30492: Ranger service should tell it's Software verison

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30492/
-----------------------------------------------------------

(Updated Feb. 23, 2015, 8:49 a.m.)


Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Changes
-------

Address the review comments :
1] Create symlink only if not present
2] Modify initd scripts to start Ranger Admin as 'ranger' user


Bugs: RANGER-210
    https://issues.apache.org/jira/browse/RANGER-210


Repository: ranger


Description
-------

Add ranger-admin and ranger-usersync that will be used to provide : start | stop | restart | version


Diffs (updated)
-----

  embeddedwebserver/scripts/ranger-admin f916dbb 
  security-admin/scripts/setup.sh beb1a55 

Diff: https://reviews.apache.org/r/30492/diff/


Testing
-------

Built tar by applying patch and tested the following on CentOS 6.5 :

1] Install ranger-admin
2] run : 'ranger-admin start' and check that ranger admin is running
3] run : 'ranger-admin stop' and check that ranger admin is stopped
4] run : '/etc/init.d/ranger-admin start' and check that ranger admin is running
5] run : '/etc/init.d/ranger-admin stop' and check that ranger admin is stopped

6] run : 'ranger-admin version' and check the version is printed

------------------------------------------------------------------------------------

1] Install ranger-usersync
2] run : 'ranger-usersync start' and check that ranger usersync is running
3] run : 'ranger-usersync stop' and check that ranger usersync is stopped
4] run : '/etc/init.d/ranger-usersync start' and check that ranger usersync is running
5] run : '/etc/init.d/ranger-usersync stop' and check that ranger usersync is stopped

6] run : 'ranger-usersync version' and check the version is printed

------------------------------------------------------------------------------------

Please note the following open issues:

1] The linking of /usr/bin/ranger-admin to $INSTALL_DIR/ews/ranger-admin-services.sh is now done as a part of installation process.

2] Running /etc/init.d/ranger-admin start as root is notsupported currently.


Thanks,

Gautam Borad


Re: Review Request 30492: Ranger service should tell it's Software verison

Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30492/#review70683
-----------------------------------------------------------



embeddedwebserver/scripts/ranger-admin
<https://reviews.apache.org/r/30492/#comment116018>

    Let's make sure this works in a service start/stop scenario and also, no ordinary user can run this in the service scenario



embeddedwebserver/scripts/ranger-admin
<https://reviews.apache.org/r/30492/#comment116019>

    Need to change "Stopping" to "Starting"



embeddedwebserver/scripts/ranger-admin-services.sh
<https://reviews.apache.org/r/30492/#comment116021>

    Seems you are deleting the existing files. This would be a back compatibility issue. I would recommend that we call this script from that script. So any existing deployment or scripts doesn't fail. We can put a note this will be removed after 2 releases, etc.
    
    Also, we should have this documented


- Don Bosco Durai


On Feb. 2, 2015, 11:52 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30492/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2015, 11:52 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-210
>     https://issues.apache.org/jira/browse/RANGER-210
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Add ranger-admin and ranger-usersync that will be used to provide : start | stop | restart | version
> 
> 
> Diffs
> -----
> 
>   embeddedwebserver/scripts/ranger-admin b1ef4f5 
>   embeddedwebserver/scripts/ranger-admin-services.sh PRE-CREATION 
>   embeddedwebserver/scripts/start-ranger-admin.sh 19df2aa 
>   embeddedwebserver/scripts/stop-ranger-admin.sh c6c4bf6 
>   pom.xml cba652e 
>   ranger-util/.gitignore PRE-CREATION 
>   ranger-util/pom.xml PRE-CREATION 
>   ranger-util/src/gen/org/apache/ranger/common/package-info.java PRE-CREATION 
>   ranger-util/src/main/java/org/apache/ranger/common/RangerVersionAnnotation.java PRE-CREATION 
>   ranger-util/src/main/java/org/apache/ranger/common/RangerVersionInfo.java PRE-CREATION 
>   ranger-util/src/scripts/saveVersion.sh PRE-CREATION 
>   security-admin/pom.xml 32d15d3 
>   security-admin/scripts/setup.sh bc241e2 
>   src/main/assembly/usersync.xml 0adb0a3 
>   ugsync/pom.xml 93b812e 
>   unixauthservice/scripts/initd e429cce 
>   unixauthservice/scripts/ranger-usersync-services.sh PRE-CREATION 
>   unixauthservice/scripts/setup.sh 5afb199 
>   unixauthservice/scripts/start.sh 399e6b2 
>   unixauthservice/scripts/stop.sh 1933364 
> 
> Diff: https://reviews.apache.org/r/30492/diff/
> 
> 
> Testing
> -------
> 
> Built tar by applying patch and tested the following on CentOS 6.5 :
> 
> 1] Install ranger-admin
> 2] run : 'ranger-admin start' and check that ranger admin is running
> 3] run : 'ranger-admin stop' and check that ranger admin is stopped
> 4] run : '/etc/init.d/ranger-admin start' and check that ranger admin is running
> 5] run : '/etc/init.d/ranger-admin stop' and check that ranger admin is stopped
> 
> 6] run : 'ranger-admin version' and check the version is printed
> 
> ------------------------------------------------------------------------------------
> 
> 1] Install ranger-usersync
> 2] run : 'ranger-usersync start' and check that ranger usersync is running
> 3] run : 'ranger-usersync stop' and check that ranger usersync is stopped
> 4] run : '/etc/init.d/ranger-usersync start' and check that ranger usersync is running
> 5] run : '/etc/init.d/ranger-usersync stop' and check that ranger usersync is stopped
> 
> 6] run : 'ranger-usersync version' and check the version is printed
> 
> ------------------------------------------------------------------------------------
> 
> Please note the following open issues:
> 
> 1] The linking of /usr/bin/ranger-admin to $INSTALL_DIR/ews/ranger-admin-services.sh is now done as a part of installation process.
> 
> 2] Running /etc/init.d/ranger-admin start as root is notsupported currently.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>