Re: [PR] Ensure SegmentDeletionManager deletes deepstore files created by BaseMultipleSegmentsConversionExecutor [pinot]

["9aman (via GitHub)" <gi...@apache.org>]

9aman commented on PR #15048:
URL: https://github.com/apache/pinot/pull/15048#issuecomment-2658176403

   > > ## Concern
   > > The `BaseMultipleSegmentsConversionExecutor` pushes segments on the path:
   > > ```
   > >  File convertedSegmentTarFile = new File(convertedTarredSegmentDir,
   > >             segmentConversionResult.getSegmentName() + TarCompressionUtils.TAR_GZ_FILE_EXTENSION);
   > > ```
   > > 
   > > 
   > >     
   > >       
   > >     
   > > 
   > >       
   > >     
   > > 
   > >     
   > >   
   > > This contains the extension `.tar.gz`
   > > While the deletion manager uses the following path for deleting the old segment
   > > `URIUtils.getUri(_dataDir, rawTableName, URIUtils.encode(segmentId));` that lacks the extension.
   > > ## Solution
   > > 
   > > * Use the existing naming convention and verify if the files exists or not.
   > > * Use the file name with `.tar.gz` extension if the file without extension does not exists.
   > > 
   > > ## Further Improvements
   > > 
   > > * Fix the code in minion by removing the extension from the file path to which the segment is written to.
   > 
   > Please update the title of this PR
   
   Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org