You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/05/23 17:07:24 UTC
[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #846:
HDDS-1555. Disable install snapshot for ContainerStateMachine.
bharatviswa504 commented on a change in pull request #846: HDDS-1555. Disable install snapshot for ContainerStateMachine.
URL: https://github.com/apache/hadoop/pull/846#discussion_r287045256
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java
##########
@@ -597,4 +603,12 @@ void handleNodeSlowness(RaftGroup group, RoleInfoProto roleInfoProto) {
void handleNoLeader(RaftGroup group, RoleInfoProto roleInfoProto) {
handlePipelineFailure(group.getGroupId(), roleInfoProto);
}
+
+ void handleInstallSnapshotFromLeader(RaftGroup group,
+ RoleInfoProto roleInfoProto, TermIndex firstTermIndexInLog) {
+ LOG.warn("Install snapshot notification received from Leader with " +
+ "termIndex : " + firstTermIndexInLog +
+ ", terminating pipeline " + group.getGroupId());
+ handlePipelineFailure(group.getGroupId(), roleInfoProto);
Review comment:
I am trying to understand this change, Jira says disable install snapshot for ContainerStateMachine.
I see that setSnapShotEnabled is set to false.
But what is the reason for handleInstallSnapShotFromLeader to call handlePipelineFailure.
Sorry, I don't have complete context of this, can you provide some explanation of this change, and why it is done, from which I can understand better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org