[PATCH] avoid branch on uninitialized variable (serf)

[Dan Christian <dc...@google.com>]

The odds this will affect real execution is 1 in 10^9, but the odds it will
obscure other valgrind errors are 1 in 1.

This is what it fixes:
==21225== Conditional jump or move depends on uninitialised value(s)
==21225==    at 0x4352C7D: handle_response (util.c:940)
==21225==    by 0x4383468: read_from_connection (context.c:742)
==21225==    by 0x43835D7: process_connection (context.c:846)
==21225==    by 0x4383806: serf_context_run (context.c:968)
==21225==    by 0x43506C3: finish_report (update.c:2137)
==21225==    by 0x427D9C6: svn_wc_crawl_revisions3 (adm_crawler.c:629)
==21225==    by 0x405D117: svn_client__update_internal (update.c:219)
==21225==    by 0x40371BB: svn_client__checkout_internal (checkout.c:138)
==21225==    by 0x4037540: svn_client_checkout2 (checkout.c:232)

[[[
Avoid branching using uninitialized data (valgrind).

* subversion/libsvn_ra_serf/serf.c
* subversion/libsvn_ra_serf/update.c
  Initialize last_status_code when conn is created.
]]]

-Dan C

Re: [PATCH] avoid branch on uninitialized variable (serf)

[Eric Gillespie <ep...@pretzelnet.org>]

"Dan Christian" <dc...@google.com> writes:

> The odds this will affect real execution is 1 in 10^9, but the odds it will
> obscure other valgrind errors are 1 in 1.

Thanks, Committed revision 25211.  (And thanks, Justin, for review)

-- 
Eric Gillespie <*> epg@pretzelnet.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org