You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/28 19:56:29 UTC
[GitHub] [camel-website] aashnajena opened a new pull request #283: Fixed
front page issues
aashnajena opened a new pull request #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283
Issue 1: Camel Kafka connecter section is not aligned with the other project sections.
Issue 2: This section's text does not have any padding on the sides for mobile screens.
Issue 3: This section has a very odd alignment for tablet view. Since other sections like projects are becoming single column and centre aligned, I think this section should follow the same design.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #283: Fixed front
page issues
Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283#issuecomment-607490043
rebased to add the right alignment of project titles, while keeping the alignment intact. Also added requested changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart merged pull request #283: Fixed front page
issues
Posted by GitBox <gi...@apache.org>.
zregvart merged pull request #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #283: Fixed front
page issues
Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283#issuecomment-605605624
Sorry for repeating some changes! Although, I don't think we need a margin all around the section. The image and the heading are related, so I'm not very convinced if we need extra margin there. Also, I was referring to the other sections on the front page - the sections about the camel projects all become single column from double columns and become center-aligned, so I'm trying to follow that design. I honestly felt it looks a little odd for the heading to be left aligned beneath the center-aligned image.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ edited a comment on issue #283: Fixed front
page issues
Posted by GitBox <gi...@apache.org>.
AemieJ edited a comment on issue #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283#issuecomment-605553906
I already made the fix to issue #2 of yours in PR #277 and according to me, if you observe the structure of all paragraphs written under docs or under blog, it only requires a margin change but not center alignment, if we want to maintain the structure-wise design.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ commented on issue #283: Fixed front page
issues
Posted by GitBox <gi...@apache.org>.
AemieJ commented on issue #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283#issuecomment-607452685
> Also, @zregvart I'm looking at the current website and issue 1 does not seem to be resolved for me on all browsers.
>
> 
If the browser size is large enough, it is going to appear like that. Only for the smaller screen width, it will easily customize and none of them are perfectly aligned with each other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ commented on issue #283: Fixed front page
issues
Posted by GitBox <gi...@apache.org>.
AemieJ commented on issue #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283#issuecomment-607132205
> I don't think this is an issue any more, can you double check?
As long as I have observed, the first issue has been resolved. For the second issue, there is this PR and PR #277 resolving it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#283: Fixed front page issues
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283#discussion_r402484556
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -248,6 +246,7 @@ section.frontpage h2 {
@media screen and (max-width: 626px) {
.split {
flex: 100%;
+ margin: 0 2rem;
Review comment:
```suggestion
margin: 0 1rem;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena commented on a change in pull request
#283: Fixed front page issues
Posted by GitBox <gi...@apache.org>.
aashnajena commented on a change in pull request #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283#discussion_r401858382
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -257,6 +257,16 @@ section.frontpage h1 {
height: 10rem;
}
+ .split {
+ padding: 0 2rem;
+ flex: 100%;
+ text-align: center;
Review comment:
Okay, if left-aligned is preferred I'll change that!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #283: Fixed front
page issues
Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283#issuecomment-607455769
Thanks for clarifying @AemieJ! The problem I was trying to solve still persists, that's all I'm saying. It should be solved and the alignment should be proper for all screen sizes. Also, @shreyaag770's PR seems to be closed. I'll make the requested changes for the Apache and Opensource section soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #283: Fixed front page
issues
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283#issuecomment-607130047
I don't think this is an issue any more, can you double check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #283: Fixed front
page issues
Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283#issuecomment-607449771
Also, @zregvart I'm looking at the current website and issue 1 does not seem to be resolved for me on all browsers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #283: Fixed front page
issues
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283#issuecomment-608034416
I've rebased this to get it to merge. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena edited a comment on issue #283: Fixed
front page issues
Posted by GitBox <gi...@apache.org>.
aashnajena edited a comment on issue #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283#issuecomment-605605624
Sorry for repeating issue 2, but I don't think we need a margin all around the section. The image and the heading are related, so I'm not very convinced if we need extra margin there. Also, I was referring to the other sections on the front page - the sections about the camel projects all become single column from double columns and become center-aligned, so I'm trying to follow that design. I honestly felt it looks a little odd for the heading to be left aligned beneath the center-aligned image.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ edited a comment on issue #283: Fixed front
page issues
Posted by GitBox <gi...@apache.org>.
AemieJ edited a comment on issue #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283#issuecomment-605553906
I already made the fix to issue #1 and issue #2 of yours in PR #274 and PR #277 and according to me, if you observe the structure of all paragraphs written under docs or under blog, it only requires a margin change but not center alignment, if we want to maintain the structure-wise design.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ commented on issue #283: Fixed front page
issues
Posted by GitBox <gi...@apache.org>.
AemieJ commented on issue #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283#issuecomment-605553906
I already made the fix to issue #2 of yours in PR #277. Please check next time too before performing the same thing, thankyou very much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#283: Fixed front page issues
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283#discussion_r401561752
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -257,6 +257,16 @@ section.frontpage h1 {
height: 10rem;
}
+ .split {
+ padding: 0 2rem;
+ flex: 100%;
+ text-align: center;
Review comment:
Not sure about aligning the text. If you'd like to center the 20 years of ASF image perhaps it's better to change the `.split img` to `display: block; margin: auto`.
Currently
Non centered text and centered image
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena commented on a change in pull request
#283: Fixed front page issues
Posted by GitBox <gi...@apache.org>.
aashnajena commented on a change in pull request #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283#discussion_r402499351
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -270,6 +269,17 @@ section.frontpage h2 {
height: 10rem;
}
+ .split {
+ padding: 0 2rem;
Review comment:
yes, I think the margin looks a bit much for the mobile screen. Made the suggested changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] shreyaag770 commented on issue #283: Fixed front
page issues
Posted by GitBox <gi...@apache.org>.
shreyaag770 commented on issue #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283#issuecomment-606712309
I have already sent a PR #264 for issue1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#283: Fixed front page issues
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #283: Fixed front page issues
URL: https://github.com/apache/camel-website/pull/283#discussion_r402484784
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -270,6 +269,17 @@ section.frontpage h2 {
height: 10rem;
}
+ .split {
+ padding: 0 2rem;
Review comment:
```suggestion
margin: 0 1rem;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services