You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vatsrahul1001 (via GitHub)" <gi...@apache.org> on 2025/03/26 10:48:20 UTC
[PR] Fix asset materialize CLI command [airflow]
vatsrahul1001 opened a new pull request, #48391:
URL: https://github.com/apache/airflow/pull/48391
closes: https://github.com/apache/airflow/issues/48382
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix asset materialize CLI command [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #48391:
URL: https://github.com/apache/airflow/pull/48391#discussion_r2015409997
##########
airflow-core/src/airflow/cli/cli_config.py:
##########
@@ -903,7 +903,7 @@ class GroupCommand(NamedTuple):
ActionCommand(
name="materialize",
help="Materialize an asset",
- func=lazy_load_command("airflow.cli.commands.asset_command.asset_materialize"),
+ func=lazy_load_command("airflow.cli.commands.remote_commands.asset_command.asset_materialize"),
Review Comment:
oh didn't notice it. I guess that means we probably don't need this one? @vatsrahul1001 could you please test it out and see whether it works well in main already? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix asset materialize CLI command [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #48391:
URL: https://github.com/apache/airflow/pull/48391#discussion_r2014601444
##########
airflow-core/src/airflow/cli/cli_config.py:
##########
@@ -903,7 +903,7 @@ class GroupCommand(NamedTuple):
ActionCommand(
name="materialize",
help="Materialize an asset",
- func=lazy_load_command("airflow.cli.commands.asset_command.asset_materialize"),
+ func=lazy_load_command("airflow.cli.commands.remote_commands.asset_command.asset_materialize"),
Review Comment:
This is now flat in `airflow-core`, where all commands are under `airflow-core/cli/commands`. It was before like this `remote_commands` and `local_commands`. Now the split is more on airflowctl containing remote and airflow containing local commands. Everything is moved in here: #48224. Let me check too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix asset materialize CLI command [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #48391:
URL: https://github.com/apache/airflow/pull/48391#issuecomment-2755219326
Seems like it is fixed in the main. Please correct me if I missed something
... `providers_manager Logs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix asset materialize CLI command [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #48391:
URL: https://github.com/apache/airflow/pull/48391#discussion_r2014601444
##########
airflow-core/src/airflow/cli/cli_config.py:
##########
@@ -903,7 +903,7 @@ class GroupCommand(NamedTuple):
ActionCommand(
name="materialize",
help="Materialize an asset",
- func=lazy_load_command("airflow.cli.commands.asset_command.asset_materialize"),
+ func=lazy_load_command("airflow.cli.commands.remote_commands.asset_command.asset_materialize"),
Review Comment:
This is now flat in `airflow-core`, where all commands are under `airflow-core/cli/commands`. It was before like this `remote_commands` and `local_commands`. Now the split is more on airflowctl containing remote and airflow containing local commands. I think this is maybe even fixed in this PR #48224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix asset materialize CLI command [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham closed pull request #48391: Fix asset materialize CLI command
URL: https://github.com/apache/airflow/pull/48391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org