[GitHub] [pinot] sajjad-moradi commented on a change in pull request #7753: Add config for enabling realtime offset based consumption status checker

[GitBox <gi...@apache.org>]

sajjad-moradi commented on a change in pull request #7753:
URL: https://github.com/apache/pinot/pull/7753#discussion_r749641860



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java
##########
@@ -242,22 +240,19 @@ public synchronized Status getServiceStatus() {
         return _serviceStatus;
       }
       long now = System.currentTimeMillis();
-      int numConsumingSegmentsNotCaughtUp = _getNumConsumingSegmentsNotReachedTheirLatestOffset.get();
+      boolean isConsumingSegmentsCounterProvided = _getNumConsumingSegmentsNotReachedTheirLatestOffset != null;

Review comment:
       That can't happen. Once a segment reaches to its latest offset, its name gets added to a helper set called `_caughtUpSegments`. In next service status calls, caught up segments will be skipped.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org