You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2016/03/30 15:32:33 UTC
[GitHub] flink pull request: [FLINK-3682] [cep] Assign processing timestamp...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/1841
[FLINK-3682] [cep] Assign processing timestamp in CEP operators
This PR fixes the problem that the CEP operators did not assign the wall clock time
as the timestamp to incoming in StreamRecords if the TimeCharacteristic was set to
ProcessingTime. Processing element with a Long.MIN_VALUE timestamp can lead to underflows
in the NFA if a positive window length is subtracted from the timestamp. For this
underflow a sanity check has been added to notify the user with an exception about it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixUnderflowPruning
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1841.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1841
----
commit 3adc65e0d65604b6255f792f00a76ec017170f0d
Author: Till Rohrmann <tr...@apache.org>
Date: 2016-03-30T13:27:21Z
[FLINK-3682] [cep] Assign processing timestamp in CEP operators
This PR fixes the problem that the CEP operators did not assign the wall clock time
as the timestamp to incoming in StreamRecords if the TimeCharacteristic was set to
ProcessingTime. Processing element with a Long.MIN_VALUE timestamp can lead to underflows
in the NFA if a positive window length is subtracted from the timestamp. For this
underflow a sanity check has been added to notify the user with an exception about it.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3682] [cep] Assign processing timestamp...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1841#issuecomment-203513525
Till's local Travis passed (https://travis-ci.org/tillrohrmann/flink/builds/119528848) with one unrelated failing build. I'm going to merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3682] [cep] Assign processing timestamp...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1841#issuecomment-203466535
Once Travis gives green light I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3682] [cep] Assign processing timestamp...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1841#issuecomment-203456547
Good catch! +1 to merge to `master` and `release-1.0`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3682] [cep] Assign processing timestamp...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1841#issuecomment-203466453
Thanks for the review @uce
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3682] [cep] Assign processing timestamp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1841
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---