[GitHub] [beam] jrmccluskey commented on a diff in pull request #17340: [BEAM-14240] Clean staticcheck warnings in runner packages

[GitBox <gi...@apache.org>]

jrmccluskey commented on code in PR #17340:
URL: https://github.com/apache/beam/pull/17340#discussion_r847705009


##########
sdks/go/pkg/beam/runners/vet/testpipeline/staticcheck.conf:
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+checks = ["inherit", "-U1000"]

Review Comment:
   Staticcheck configs can be applied per-directory. We can exempt the testpipeline code from the U1000 check (function not being used) and inherit check exemptions from higher up in the hierarchy if they exist. Eventually a top-level config would be the default checks minus the deprecation checker, but we don't want to ignore unused code in the entire Go SDK.
   
   See https://staticcheck.io/docs/configuration/ for more info



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org