You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2019/09/24 14:57:21 UTC

[GitHub] [accumulo] lbschanno commented on a change in pull request #1374: WIP: Give ThriftTransportPool higher concurrent granularity

lbschanno commented on a change in pull request #1374: WIP: Give ThriftTransportPool higher concurrent granularity
URL: https://github.com/apache/accumulo/pull/1374#discussion_r327665248
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/clientImpl/ThriftTransportPool.java
 ##########
 @@ -564,9 +556,12 @@ public void returnTransport(TTransport tsc) {
           existInCache = true;
         }
       }
+    }finally {
+      lock.unlock();
     }
 
     // close outside of sync block
+    // TODO - Might need to close within lock block.
 
 Review comment:
   Understood.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services