You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cashmand (via GitHub)" <gi...@apache.org> on 2024/01/15 20:20:40 UTC
[PR] [SPARK-45827] Disallow partitioning on Variant column [spark]
cashmand opened a new pull request, #44742:
URL: https://github.com/apache/spark/pull/44742
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Follow-up to https://github.com/apache/spark/pull/43984: we should not allow partitioning on VariantType. Even though it is is an atomic type, it represents a nested semi-structured value, so not partitioning is consistent with our decision to not allow partitioning on nested types. Also, for now at least, it is not even comparable, so attempting to partition fails with a confusing codegen error about a method named `compare` not being declared.
### Why are the changes needed?
Improves error message when attempting to partition on Variant, and explicitly forbids a case that we do not intend to support.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Added unit test, which fails without the code change.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45827] Disallow partitioning on Variant column [spark]
Posted by "cashmand (via GitHub)" <gi...@apache.org>.
cashmand commented on code in PR #44742:
URL: https://github.com/apache/spark/pull/44742#discussion_r1458212982
##########
sql/core/src/test/scala/org/apache/spark/sql/VariantSuite.scala:
##########
@@ -138,4 +138,35 @@ class VariantSuite extends QueryTest with SharedSparkSession {
}
}
}
+
+ test("write partitioned file") {
+ def verifyResult(df: DataFrame): Unit = {
+ val result = df.selectExpr("v").collect()
+ .map(_.get(0).asInstanceOf[VariantVal].toString)
+ .sorted
+ .toSeq
+ val expected = (1 until 10).map(id => "1" * id)
+ assert(result == expected)
+ }
+
+ // At this point, JSON parsing logic is not really implemented. We just construct some number
+ // inputs that are also valid JSON. This exercises passing VariantVal throughout the system.
+ val query = spark.sql("select id, parse_json(repeat('1', id)) as v from range(1, 10)")
+ verifyResult(query)
+
+ // Partition by another column should work.
+ withTempDir { dir =>
+ val tempDir = new File(dir, "files").getCanonicalPath
+ query.write.partitionBy("id").parquet(tempDir)
+ verifyResult(spark.read.parquet(tempDir))
+ }
+
+ // Partitioning by Variant column is not allowed.
+ withTempDir { dir =>
+ val tempDir = new File(dir, "files").getCanonicalPath
+ intercept[AnalysisException] {
+ query.write.partitionBy("v").parquet(tempDir)
Review Comment:
Thanks for the review, I added the extra cases to the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45827] Disallow partitioning on Variant column [spark]
Posted by "cashmand (via GitHub)" <gi...@apache.org>.
cashmand commented on PR #44742:
URL: https://github.com/apache/spark/pull/44742#issuecomment-1895960888
@cloud-fan, could you please review, or suggest a reviewer? I'm not sure what the `On pull request update` check failure means, or if there's anything I should do about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45827] Disallow partitioning on Variant column [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #44742: [SPARK-45827] Disallow partitioning on Variant column
URL: https://github.com/apache/spark/pull/44742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45827] Disallow partitioning on Variant column [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44742:
URL: https://github.com/apache/spark/pull/44742#discussion_r1458167084
##########
sql/core/src/test/scala/org/apache/spark/sql/VariantSuite.scala:
##########
@@ -138,4 +138,35 @@ class VariantSuite extends QueryTest with SharedSparkSession {
}
}
}
+
+ test("write partitioned file") {
+ def verifyResult(df: DataFrame): Unit = {
+ val result = df.selectExpr("v").collect()
+ .map(_.get(0).asInstanceOf[VariantVal].toString)
+ .sorted
+ .toSeq
+ val expected = (1 until 10).map(id => "1" * id)
+ assert(result == expected)
+ }
+
+ // At this point, JSON parsing logic is not really implemented. We just construct some number
+ // inputs that are also valid JSON. This exercises passing VariantVal throughout the system.
+ val query = spark.sql("select id, parse_json(repeat('1', id)) as v from range(1, 10)")
+ verifyResult(query)
+
+ // Partition by another column should work.
+ withTempDir { dir =>
+ val tempDir = new File(dir, "files").getCanonicalPath
+ query.write.partitionBy("id").parquet(tempDir)
+ verifyResult(spark.read.parquet(tempDir))
+ }
+
+ // Partitioning by Variant column is not allowed.
+ withTempDir { dir =>
+ val tempDir = new File(dir, "files").getCanonicalPath
+ intercept[AnalysisException] {
+ query.write.partitionBy("v").parquet(tempDir)
Review Comment:
Can we test more cases? e.g. `.saveAsTable`, and the SQL CTAS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45827] Disallow partitioning on Variant column [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #44742:
URL: https://github.com/apache/spark/pull/44742#issuecomment-1901658912
the failure is unrelated, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org