[GitHub] [beam] suztomo commented on a change in pull request #11125: [BEAM-9444] Use Google Cloud Libraries BOM to set GCP library dependencies

[GitBox <gi...@apache.org>]

suztomo commented on a change in pull request #11125: [BEAM-9444] Use Google Cloud Libraries BOM to set GCP library dependencies
URL: https://github.com/apache/beam/pull/11125#discussion_r392456523
 
 

 ##########
 File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
 ##########
 @@ -1274,7 +1276,7 @@ class BeamModulePlugin implements Plugin<Project> {
         // has different dependencies than our project.
         if (config.getName() != "errorprone" && !inDependencyUpdates) {
           config.resolutionStrategy {
-            force project.library.java.values()
+            force project.library.java.values().findAll { it.split(':').size() > 2 }
 
 Review comment:
   `force project.library.java.values()` does not take GCP libraries BOM into account. So excluding the versionless coordinates.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services