You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Florian Holeczek (JIRA)" <ji...@apache.org> on 2008/02/16 18:17:07 UTC
[jira] Created: (JSPWIKI-187) MailUtil issues
MailUtil issues
---------------
Key: JSPWIKI-187
URL: https://issues.apache.org/jira/browse/JSPWIKI-187
Project: JSPWiki
Issue Type: Bug
Components: Core & storage
Affects Versions: 2.6.1
Reporter: Florian Holeczek
Priority: Minor
As I've been announcing on the list, here comes a patch regarding issues 102, 166 and 169:
{quote}
Hi Janne,
could you please have a look at JSPWIKI-166 and 169 and then wait a bit before releasing 2.6.1?
I'd like to have a final look at it and add an improvement I mentioned in JSPWIKI-102 (improving exception handling and logging regarding usage of JNDI or custom mail).
Would be fine if these MailUtil issues could be fixed completely with 2.6.1 final.
Regards,
Florian
{quote}
I've done a review on MailUtil and done several tests using JNDI and custom mail sessions.
* This patch improves the information flow to the standard user (log level info) as well as the administrator (log level debug).
* Additionally, I've found and fixed a bug: mail.smtp.timeout and mail.smtp.connectiontimeout weren't read out of jspwiki.properties.
* The patch for jspwiki.properties.tmpl should make mail configuration clearer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-187) MailUtil issues
Posted by "Florian Holeczek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569684#action_12569684 ]
Florian Holeczek commented on JSPWIKI-187:
------------------------------------------
Divided this issue in two parts JSPWIKI-188 (usability) and JSPWIKI-189 (bug). Please have a look at these in this order.
> MailUtil issues
> ---------------
>
> Key: JSPWIKI-187
> URL: https://issues.apache.org/jira/browse/JSPWIKI-187
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.6.1
> Reporter: Florian Holeczek
> Priority: Minor
> Attachments: JSPWIKI-187_patch.zip
>
>
> As I've been announcing on the list, here comes a patch regarding issues 102, 166 and 169:
> {quote}
> Hi Janne,
> could you please have a look at JSPWIKI-166 and 169 and then wait a bit before releasing 2.6.1?
> I'd like to have a final look at it and add an improvement I mentioned in JSPWIKI-102 (improving exception handling and logging regarding usage of JNDI or custom mail).
> Would be fine if these MailUtil issues could be fixed completely with 2.6.1 final.
> Regards,
> Florian
> {quote}
> I've done a review on MailUtil and done several tests using JNDI and custom mail sessions.
> * This patch improves the information flow to the standard user (log level info) as well as the administrator (log level debug).
> * Additionally, I've found and fixed a bug: mail.smtp.timeout and mail.smtp.connectiontimeout weren't read out of jspwiki.properties.
> * The patch for jspwiki.properties.tmpl should make mail configuration clearer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JSPWIKI-187) MailUtil issues
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Janne Jalkanen resolved JSPWIKI-187.
------------------------------------
Resolution: Won't Fix
Split into two patches.
> MailUtil issues
> ---------------
>
> Key: JSPWIKI-187
> URL: https://issues.apache.org/jira/browse/JSPWIKI-187
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.6.1
> Reporter: Florian Holeczek
> Priority: Minor
> Attachments: JSPWIKI-187_patch.zip
>
>
> As I've been announcing on the list, here comes a patch regarding issues 102, 166 and 169:
> {quote}
> Hi Janne,
> could you please have a look at JSPWIKI-166 and 169 and then wait a bit before releasing 2.6.1?
> I'd like to have a final look at it and add an improvement I mentioned in JSPWIKI-102 (improving exception handling and logging regarding usage of JNDI or custom mail).
> Would be fine if these MailUtil issues could be fixed completely with 2.6.1 final.
> Regards,
> Florian
> {quote}
> I've done a review on MailUtil and done several tests using JNDI and custom mail sessions.
> * This patch improves the information flow to the standard user (log level info) as well as the administrator (log level debug).
> * Additionally, I've found and fixed a bug: mail.smtp.timeout and mail.smtp.connectiontimeout weren't read out of jspwiki.properties.
> * The patch for jspwiki.properties.tmpl should make mail configuration clearer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-187) MailUtil issues
Posted by "Florian Holeczek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569664#action_12569664 ]
Florian Holeczek commented on JSPWIKI-187:
------------------------------------------
{quote}Please, single patch against a single issue only.{quote}
Ok, I'll separate this into usability and bugfix.
{quote}Also, JSPWIKI-166 and JSPWIKI-102 are already fixed, so I don't understand the point of this issue.{quote}
That's why I've quoted my mail:
{quote}I'd like to have a final look at it and add an improvement I mentioned in JSPWIKI-102 (improving exception handling and logging regarding usage of JNDI or custom mail).{quote}
So, it doesn't have to do anything directly with JSPWIKI-102, but I've mentioned "(improving exception handling and logging regarding usage of JNDI or custom mail)" there. JSPWIKI-166 and JSPWIKI-169 were mentioned, because originally, I wanted you to handle these issues, before I could do anything further in MailUtil. Then, you didn't have much time and forgot about this request, I guess.
Overall, there are two points:
* First, at the moment, if there are any errors or misconfigurations with mail, the user simply won't be able to find anything useful in the logs. That's the main point of this issue.
* Second, while reviewing it, I've found the mentioned bug.
I hope now it's clear to you why I'm referring to all these issues?
> MailUtil issues
> ---------------
>
> Key: JSPWIKI-187
> URL: https://issues.apache.org/jira/browse/JSPWIKI-187
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.6.1
> Reporter: Florian Holeczek
> Priority: Minor
> Attachments: JSPWIKI-187_patch.zip
>
>
> As I've been announcing on the list, here comes a patch regarding issues 102, 166 and 169:
> {quote}
> Hi Janne,
> could you please have a look at JSPWIKI-166 and 169 and then wait a bit before releasing 2.6.1?
> I'd like to have a final look at it and add an improvement I mentioned in JSPWIKI-102 (improving exception handling and logging regarding usage of JNDI or custom mail).
> Would be fine if these MailUtil issues could be fixed completely with 2.6.1 final.
> Regards,
> Florian
> {quote}
> I've done a review on MailUtil and done several tests using JNDI and custom mail sessions.
> * This patch improves the information flow to the standard user (log level info) as well as the administrator (log level debug).
> * Additionally, I've found and fixed a bug: mail.smtp.timeout and mail.smtp.connectiontimeout weren't read out of jspwiki.properties.
> * The patch for jspwiki.properties.tmpl should make mail configuration clearer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-187) MailUtil issues
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569682#action_12569682 ]
Janne Jalkanen commented on JSPWIKI-187:
----------------------------------------
Yup, gotcha. I don't in general look into issues once they are closed, so that's why it's not that useful to add comments to them... I go through the open issue list like weekly!
> MailUtil issues
> ---------------
>
> Key: JSPWIKI-187
> URL: https://issues.apache.org/jira/browse/JSPWIKI-187
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.6.1
> Reporter: Florian Holeczek
> Priority: Minor
> Attachments: JSPWIKI-187_patch.zip
>
>
> As I've been announcing on the list, here comes a patch regarding issues 102, 166 and 169:
> {quote}
> Hi Janne,
> could you please have a look at JSPWIKI-166 and 169 and then wait a bit before releasing 2.6.1?
> I'd like to have a final look at it and add an improvement I mentioned in JSPWIKI-102 (improving exception handling and logging regarding usage of JNDI or custom mail).
> Would be fine if these MailUtil issues could be fixed completely with 2.6.1 final.
> Regards,
> Florian
> {quote}
> I've done a review on MailUtil and done several tests using JNDI and custom mail sessions.
> * This patch improves the information flow to the standard user (log level info) as well as the administrator (log level debug).
> * Additionally, I've found and fixed a bug: mail.smtp.timeout and mail.smtp.connectiontimeout weren't read out of jspwiki.properties.
> * The patch for jspwiki.properties.tmpl should make mail configuration clearer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-187) MailUtil issues
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569616#action_12569616 ]
Janne Jalkanen commented on JSPWIKI-187:
----------------------------------------
Please, single patch against a single issue only. Otherwise things get unmanageable. Also, JSPWIKI-166 and JSPWIKI-102 are already fixed, so I don't understand the point of this issue.
Propose for WONTFIX, and request to file each issue separately.
> MailUtil issues
> ---------------
>
> Key: JSPWIKI-187
> URL: https://issues.apache.org/jira/browse/JSPWIKI-187
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.6.1
> Reporter: Florian Holeczek
> Priority: Minor
> Attachments: JSPWIKI-187_patch.zip
>
>
> As I've been announcing on the list, here comes a patch regarding issues 102, 166 and 169:
> {quote}
> Hi Janne,
> could you please have a look at JSPWIKI-166 and 169 and then wait a bit before releasing 2.6.1?
> I'd like to have a final look at it and add an improvement I mentioned in JSPWIKI-102 (improving exception handling and logging regarding usage of JNDI or custom mail).
> Would be fine if these MailUtil issues could be fixed completely with 2.6.1 final.
> Regards,
> Florian
> {quote}
> I've done a review on MailUtil and done several tests using JNDI and custom mail sessions.
> * This patch improves the information flow to the standard user (log level info) as well as the administrator (log level debug).
> * Additionally, I've found and fixed a bug: mail.smtp.timeout and mail.smtp.connectiontimeout weren't read out of jspwiki.properties.
> * The patch for jspwiki.properties.tmpl should make mail configuration clearer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.