You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/24 04:17:01 UTC

[GitHub] [skywalking-kubernetes] kezhenxu94 commented on a change in pull request #72: update oap-deployment with danamic add more ports.

kezhenxu94 commented on a change in pull request #72:
URL: https://github.com/apache/skywalking-kubernetes/pull/72#discussion_r657612420



##########
File path: chart/skywalking/values.yaml
##########
@@ -38,8 +38,10 @@ oap:
     pullPolicy: IfNotPresent
   storageType: null
   ports:
+    # add more ports here if you need
     grpc: 11800
     rest: 12800
+    zabbix: 10051

Review comment:
       Can we make this as an example comment? I think it is not very widely used, my suggestion is 
   
   ```
   # add more ports here if you need, for example
   # zabbix: 10051
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org