You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2010/12/28 01:34:45 UTC

[jira] Created: (HADOOP-7079) Refactor IPC proxy creation to use Builder pattern

Refactor IPC proxy creation to use Builder pattern
--------------------------------------------------

                 Key: HADOOP-7079
                 URL: https://issues.apache.org/jira/browse/HADOOP-7079
             Project: Hadoop Common
          Issue Type: Improvement
          Components: ipc
    Affects Versions: 0.23.0
            Reporter: Todd Lipcon
         Attachments: hadoop-7079-prelim.txt

The various RPC proxy creation methods are getting really messy, with 7 or 8 arguments which get tracked through a long chain of method calls. I'm interested in refactoring these to use a Builder pattern to make it easier to add new settings for RPC without a messy patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HADOOP-7079) Refactor IPC proxy creation to use Builder pattern

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-7079:
--------------------------------

    Attachment: hadoop-7079-prelim.txt

here's a preliminary sketch just to gather feedback if others agree this is worth pursuing.

> Refactor IPC proxy creation to use Builder pattern
> --------------------------------------------------
>
>                 Key: HADOOP-7079
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7079
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>         Attachments: hadoop-7079-prelim.txt
>
>
> The various RPC proxy creation methods are getting really messy, with 7 or 8 arguments which get tracked through a long chain of method calls. I'm interested in refactoring these to use a Builder pattern to make it easier to add new settings for RPC without a messy patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HADOOP-7079) Refactor IPC proxy creation to use Builder pattern

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975507#action_12975507 ] 

Owen O'Malley commented on HADOOP-7079:
---------------------------------------

Actually, you should consider the pattern that has been added to FileContext.create and SequenceFiles. I find it easier to read that the builder pattern, but your mileage may vary.

> Refactor IPC proxy creation to use Builder pattern
> --------------------------------------------------
>
>                 Key: HADOOP-7079
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7079
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>         Attachments: hadoop-7079-prelim.txt
>
>
> The various RPC proxy creation methods are getting really messy, with 7 or 8 arguments which get tracked through a long chain of method calls. I'm interested in refactoring these to use a Builder pattern to make it easier to add new settings for RPC without a messy patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.