[GitHub] [druid] maytasm commented on a diff in pull request #12392: Make tombstones ingestible by having them return an empty result set.

[GitBox <gi...@apache.org>]

maytasm commented on code in PR #12392:
URL: https://github.com/apache/druid/pull/12392#discussion_r847892891


##########
server/src/main/java/org/apache/druid/server/coordinator/duty/CompactSegments.java:
##########
@@ -426,6 +426,17 @@ private CoordinatorStats doRun(
         if (config.getIoConfig() != null) {
           dropExisting = config.getIoConfig().isDropExisting();
         }
+        // force dropExisting to true if dropExisting is not set,
+        // dropExistingis false,
+        // or all segments to compact are tombstones.
+        // Otherwise, auto-compaction will cycle indefinitely since segments won't be compacted and their
+        // compaction state won't be set

Review Comment:
   `storeCompactionState` should not be used. It can be set by the user and apply to non compaction task (i.e. batch ingestion reading data from s3).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org