You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Savalek <gi...@git.apache.org> on 2018/01/29 16:15:24 UTC
[GitHub] zeppelin pull request #2749: [ZEPPELIN-3180] BUGFIX - save operation on inte...
GitHub user Savalek opened a pull request:
https://github.com/apache/zeppelin/pull/2749
[ZEPPELIN-3180] BUGFIX - save operation on interpreter add whitespace to permissions
### What is this PR for?
This PR fixes a bug when unnecessary spaces are added to the permissions.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
[ZEPPELIN-3180](https://issues.apache.org/jira/browse/ZEPPELIN-3180)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Savalek/zeppelin ZEPPELIN-3180
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2749.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2749
----
commit 0d4a9001b1d597f72161e3f39e7777e95e08aad1
Author: Savalek <de...@...>
Date: 2018-01-25T09:01:15Z
[ZEPPELIN-3180] FIX - interpreter add whitespace to permissions
----
---
[GitHub] zeppelin issue #2749: [ZEPPELIN-3180] BUGFIX - save operation on interpreter...
Posted by weand <gi...@git.apache.org>.
Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2749
any progress here?
---
[GitHub] zeppelin issue #2749: [ZEPPELIN-3180] BUGFIX - save operation on interpreter...
Posted by weand <gi...@git.apache.org>.
Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2749
*no more comment*, we really would like to see this feature in master and branch-0.8 branches
---
[GitHub] zeppelin issue #2749: [ZEPPELIN-3180] BUGFIX - save operation on interpreter...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2749
merging if no more comment
---
[GitHub] zeppelin pull request #2749: [ZEPPELIN-3180] BUGFIX - save operation on inte...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2749
---
[GitHub] zeppelin pull request #2749: [ZEPPELIN-3180] BUGFIX - save operation on inte...
Posted by Savalek <gi...@git.apache.org>.
Github user Savalek closed the pull request at:
https://github.com/apache/zeppelin/pull/2749
---
[GitHub] zeppelin pull request #2749: [ZEPPELIN-3180] BUGFIX - save operation on inte...
Posted by Savalek <gi...@git.apache.org>.
GitHub user Savalek reopened a pull request:
https://github.com/apache/zeppelin/pull/2749
[ZEPPELIN-3180] BUGFIX - save operation on interpreter add whitespace to permissions
### What is this PR for?
This PR fixes a bug when unnecessary spaces are added to the permissions.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
[ZEPPELIN-3180](https://issues.apache.org/jira/browse/ZEPPELIN-3180)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Savalek/zeppelin ZEPPELIN-3180
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2749.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2749
----
commit 0d4a9001b1d597f72161e3f39e7777e95e08aad1
Author: Savalek <de...@...>
Date: 2018-01-25T09:01:15Z
[ZEPPELIN-3180] FIX - interpreter add whitespace to permissions
commit 28c537e69f5feb3186fd6294037781883e26ff28
Author: Savalek <de...@...>
Date: 2018-02-09T14:15:28Z
[ZEPPELIN-3212] add test
commit 84ee2cb4bac67e62f30690158ad30694aea1d311
Author: Savalek <de...@...>
Date: 2018-02-09T14:15:53Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-3180
commit b2f58fb6b85d9479ba58b9e47dc24a0050f79590
Author: Savalek <de...@...>
Date: 2018-02-09T14:21:36Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-3180
----
---
[GitHub] zeppelin issue #2749: [ZEPPELIN-3180] BUGFIX - save operation on interpreter...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2749
@weand Could you rerun the test ?
---
[GitHub] zeppelin issue #2749: [ZEPPELIN-3180] BUGFIX - save operation on interpreter...
Posted by weand <gi...@git.apache.org>.
Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2749
LGTM @felixcheung what do you think?
---
[GitHub] zeppelin issue #2749: [ZEPPELIN-3180] BUGFIX - save operation on interpreter...
Posted by Savalek <gi...@git.apache.org>.
Github user Savalek commented on the issue:
https://github.com/apache/zeppelin/pull/2749
@felixcheung, I did a rebase.
An error in the tests of the Travis is the same as in master's branch.
---
[GitHub] zeppelin issue #2749: [ZEPPELIN-3180] BUGFIX - save operation on interpreter...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2749
doesn't seem like the test failure is related https://api.travis-ci.org/v3/job/339570673/log.txt
@Savalek could you rebase this PR?
---