You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Martin Cooper <ma...@apache.org> on 2007/03/06 02:19:55 UTC

Re: svn commit: r514940 [1/3] - in /struts/struts2/trunk/plugins/dojo/src: main/java/org/apache/struts2/components/ main/java/org/apache/struts2/dojo/ main/java/org/apache/struts2/dojo/components/ main/java/org/apache/struts2/dojo/views/ main/java/or

Musachy, *please* learn to use 'svn move'! This should have been an 'svn
move' to retain history, and then an edit later. Yet again, we're losing the
history here, and you've made it much harder for us to verify that nothing
was inadvertently changed / broken in the process.

--
Martin Cooper


On 3/5/07, musachy@apache.org <mu...@apache.org> wrote:
>
> Author: musachy
> Date: Mon Mar  5 17:11:06 2007
> New Revision: 514940
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=514940
> Log:
> Move classes to "dojo" package so they don't conflict with the ones from
> core
>

Re: svn commit: r514940 [1/3] - in /struts/struts2/trunk/plugins/dojo/src: main/java/org/apache/struts2/components/ main/java/org/apache/struts2/dojo/ main/java/org/apache/struts2/dojo/components/ main/java/org/apache/struts2/dojo/views/ main/java/or

Posted by Musachy Barroso <mu...@gmail.com>.
Yes, as they were moved their namespaces changed, among other minor things.

musachy

On 3/5/07, Wendy Smoak <ws...@gmail.com> wrote:
>
> On 3/5/07, Musachy Barroso <mu...@gmail.com> wrote:
>
> > Sorry to spoil it, but I *did use svn move*:
> >
> > http://svn.apache.org/viewvc?view=rev&revision=514940
>
> If it was simply a move, there shouldn't have been any "diffs", just
> the list of files.
>
> Many of the files were "copied, changed from r514939", yet the commit
> message only mentions moving them.  Were the changes intentional?
>
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>


-- 
"Hey you! Would you help me to carry the stone?" Pink Floyd

Re: svn commit: r514940 [1/3] - in /struts/struts2/trunk/plugins/dojo/src: main/java/org/apache/struts2/components/ main/java/org/apache/struts2/dojo/ main/java/org/apache/struts2/dojo/components/ main/java/org/apache/struts2/dojo/views/ main/java/or

Posted by Wendy Smoak <ws...@gmail.com>.
On 3/5/07, Musachy Barroso <mu...@gmail.com> wrote:

> Sorry to spoil it, but I *did use svn move*:
>
> http://svn.apache.org/viewvc?view=rev&revision=514940

If it was simply a move, there shouldn't have been any "diffs", just
the list of files.

Many of the files were "copied, changed from r514939", yet the commit
message only mentions moving them.  Were the changes intentional?

-- 
Wendy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: svn commit: r514940 [1/3] - in /struts/struts2/trunk/plugins/dojo/src: main/java/org/apache/struts2/components/ main/java/org/apache/struts2/dojo/ main/java/org/apache/struts2/dojo/components/ main/java/org/apache/struts2/dojo/views/ main/java/or

Posted by Musachy Barroso <mu...@gmail.com>.
Sorry to spoil it, but I *did use svn move*:

http://svn.apache.org/viewvc?view=rev&revision=514940

musachy

On 3/5/07, Martin Cooper <ma...@apache.org> wrote:
>
> Musachy, *please* learn to use 'svn move'! This should have been an 'svn
> move' to retain history, and then an edit later. Yet again, we're losing
> the
> history here, and you've made it much harder for us to verify that nothing
> was inadvertently changed / broken in the process.
>
> --
> Martin Cooper
>
>
> On 3/5/07, musachy@apache.org <mu...@apache.org> wrote:
> >
> > Author: musachy
> > Date: Mon Mar  5 17:11:06 2007
> > New Revision: 514940
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=514940
> > Log:
> > Move classes to "dojo" package so they don't conflict with the ones from
> > core
> >
>



-- 
"Hey you! Would you help me to carry the stone?" Pink Floyd