[GitHub] dongjoon-hyun commented on a change in pull request #23912: [SPARK-21029][SS] StreamingQuery should be stopped when the SparkSession is stopped

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #23912: [SPARK-21029][SS] StreamingQuery should be stopped when the SparkSession is stopped
URL: https://github.com/apache/spark/pull/23912#discussion_r261832855
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
 ##########
 @@ -742,6 +749,22 @@ class SparkSession private(
     DataType.fromJson(dataTypeString)
   }
 
+  /**
+   * Stops all active streaming queries
+   */
+  private def stopStreamingQueries(): Unit = {
 
 Review comment:
   In that case, companion object will be the right solution. Could you try to make and use `object StreamingQueryManager`? We had better collect the logic into one place.
   
   Also, cc @jose-torres , @tdas , @zsxwing, @cloud-fan  since this is a design issue for `StreamingQueryManager`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org