You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/05/02 18:02:12 UTC
[jira] [Commented] (THRIFT-3812) Option to prefix namespace to
Swift type names
[ https://issues.apache.org/jira/browse/THRIFT-3812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266880#comment-15266880 ]
ASF GitHub Bot commented on THRIFT-3812:
----------------------------------------
GitHub user zhaakhi opened a pull request:
https://github.com/apache/thrift/pull/1002
THRIFT-3812 Add option to prefix namespace Swift type names
Swift does not appear to have a way to namespace things within a single pod.
This adds an option swift:prefix_namespace that will add Cocoa-style prefixes to the generated code if the file has a defined Swift namespace.
E.g. if a file has
"namespace swift ABC"
then the struct "MyStruct" will be renamed to "ABCMyStruct"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhaakhi/thrift THRIFT-3812
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1002.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1002
----
commit a7239140a64ae95ddf06d057070b4bbde2bc7895
Author: Håkon Hitland <ha...@zedge.net>
Date: 2016-04-20T19:59:42Z
THRIFT-3812 Add option to prefix namespace Swift type names
Swift does not appear to have a way to namespace things within a single
pod.
This adds an option swift:prefix_namespace that will add Cocoa-style
prefixes to the generated code if the file has a defined Swift
namespace.
E.g. if a file has
"namespace swift ABC"
then the struct "MyStruct" will be renamed to "ABCMyStruct"
----
> Option to prefix namespace to Swift type names
> ----------------------------------------------
>
> Key: THRIFT-3812
> URL: https://issues.apache.org/jira/browse/THRIFT-3812
> Project: Thrift
> Issue Type: New Feature
> Components: Swift - Compiler
> Reporter: Håkon Hitland
> Priority: Minor
>
> Swift does have a way to namespace things within a pod, which can lead to name collisions.
> This adds an option "swift:prefix_namespace" that will add Cocoa-style prefixes to the generated code if the file has a defined Swift namespace.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)