[GitHub] [james-project] chibenwa commented on a change in pull request #264: JAMES-3225 configures CI for builds.apache.org

[GitBox <gi...@apache.org>]

chibenwa commented on a change in pull request #264:
URL: https://github.com/apache/james-project/pull/264#discussion_r571849215



##########
File path: mailbox/cassandra/src/test/java/org/apache/james/mailbox/cassandra/mail/CassandraMailboxMapperTest.java
##########
@@ -59,10 +60,7 @@
 import org.apache.james.mailbox.model.search.Wildcard;
 import org.apache.james.mailbox.store.MailboxReactorUtils;
 import org.assertj.core.api.SoftAssertions;
-import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Disabled;
-import org.junit.jupiter.api.Nested;
-import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.*;

Review comment:
       Wildcard spotted ;-)

##########
File path: backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/DockerCassandra.java
##########
@@ -118,11 +126,36 @@ private void grantPermissionToTestingUser(Cluster privilegedCluster, String keys
 
     @SuppressWarnings("resource")
     public DockerCassandra() {
-        this("cassandra_3_11_3", AdditionalDockerFileStep.IDENTITY);
+        this("cassandra_3_11_3-"+ UUID.randomUUID().toString(), AdditionalDockerFileStep.IDENTITY);

Review comment:
       `UUID.randomUUID().toString()` this means that we might end up building a new image for each invocation.
   
   An idea to allow multiple builds to hare the same docket daemon could be to realy on a build ID environment variable as a differenciator.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org