You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/07/07 02:03:37 UTC
[GitHub] [incubator-eventmesh] kirinzhu opened a new issue, #999: [Enhancement] Consider implementing the Serializable interface
kirinzhu opened a new issue, #999:
URL: https://github.com/apache/incubator-eventmesh/issues/999
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
This class implements the Comparator interface. Maybe we consider whether or not it should also implement the Serializable interface. If a comparator is used to construct an ordered collection such as a TreeMap, then the TreeMap will be serializable only if the comparator is also serializable. Making them serializable is good defensive programming and could enhance the robustness of the program
### Describe the solution you'd like
In module eventmesh-runtime
In class org.apache.eventmesh.runtime.util.ValueComparator
At [lines 23-29]
Consider implementing the Serializable interface
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] misselvexu commented on issue #999: [Enhancement] Consider implementing the Serializable interface
Posted by GitBox <gi...@apache.org>.
misselvexu commented on issue #999:
URL: https://github.com/apache/incubator-eventmesh/issues/999#issuecomment-1180141602
I will finish this issue .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] HeZean commented on issue #999: [Enhancement] Consider implementing the Serializable interface
Posted by GitBox <gi...@apache.org>.
HeZean commented on issue #999:
URL: https://github.com/apache/incubator-eventmesh/issues/999#issuecomment-1209621266
[WeOpen Star] working on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 closed issue #999: [Enhancement] Consider implementing the Serializable interface
Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #999: [Enhancement] Consider implementing the Serializable interface
URL: https://github.com/apache/incubator-eventmesh/issues/999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org