You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "John Durham (Jira)" <ji...@apache.org> on 2023/03/18 18:51:00 UTC
[jira] [Comment Edited] (SOLR-16468) Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (collection level)
[ https://issues.apache.org/jira/browse/SOLR-16468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702159#comment-17702159 ]
John Durham edited comment on SOLR-16468 at 3/18/23 6:50 PM:
-------------------------------------------------------------
Hi Jason - I started a [Draft PR|https://github.com/apache/solr/pull/1471] that should contain LIST, CREATE, and DELETE collection snapshot resources. I still need to add tests and update docs, but had some questions regarding those two topics:
# Is there an abstract class I can use to create tests for Collection level code? I did some looking around the test suite, but nothing stuck out to me. I also considered doing some mocking, but wanted to avoid that if there was a better way of testing available.
# Looking through the existing adocs, I didn't see anything documenting the Collection snapshots. Is that something we want to start for the V2 APIs? I'm thinking if we did, they would probably be located in documentation regarding backup/restore functionality. What do you think?
was (Author: jdurham):
Hi Jason - I started a [Draft PR|https://github.com/apache/solr/pull/1471] that should contain LIST, CREATE, and DELETE snapshot collection. I still need to add tests and update docs, but had some questions regarding those two topics:
# Is there an abstract class I can use to create tests for Collection level code? I did some looking around the test suite, but nothing stuck out to me. I also considered doing some mocking, but wanted to avoid that if there was a better way of testing available.
# Looking through the existing adocs, I didn't see anything documenting the Collection snapshots. Is that something we want to start for the V2 APIs? I'm thinking if we did, they would probably be located in documentation regarding backup/restore functionality. What do you think?
> Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (collection level)
> ---------------------------------------------------------------------------------------------------
>
> Key: SOLR-16468
> URL: https://issues.apache.org/jira/browse/SOLR-16468
> Project: Solr
> Issue Type: Sub-task
> Components: v2 API
> Affects Versions: 9.2
> Reporter: Sanjay Dutt
> Assignee: Jason Gerlowski
> Priority: Major
> Labels: V2, newdev
>
> Snapshot API has no v2 equivalent at collection level. This ticket is to track changes made to the Solr to add v2 equivalent of 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' api.
> Proposed API design
> * collection CREATESNAPSHOT - POST /api/collections/collName/snapshots/snapshotName
> * collection LISTSNAPSHOT - GET /api/collections/collName/snapshots
> * collection DELETESNAPSHOT - DELETE /api/collections/collName/snapshots/snapshotName
> A few other pointers that might be helpful, especially for newcomers:
> * The v1 logic for this API lives in CollectionsHandler (for the collection-level APIs) and CoreAdminHandler (for the core-level APIs).
> * Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" section.)
> * A step-by-step guide to creating APIs using the preferred v2 API framework
> * [A recent PR that adds a v2 API, as an example|https://github.com/apache/solr/pull/1061/files]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org