[GitHub] [beam] cozos edited a comment on pull request #16126: [BEAM-13052] Increment pubsub python version and fix breakages.

[GitBox <gi...@apache.org>]

cozos edited a comment on pull request #16126:
URL: https://github.com/apache/beam/pull/16126#issuecomment-1079243789


   I did not have to change any Beam pipeline code, but I did have to install the `2.x` pubsub client, which did have breaking changes from the `1.x` pubsub client. So a transitive breakage, I guess. 
   
   I was under the impression that this was something that was meant to be documented in the changelog from this comment:
   
   > Can you document the breaking change for the Pub/Sub client in the CL description ?
   >
   > LGTM other than that.
   
   If not, then that's fine I guess. But I think it would be helpful to changelog readers ("if you're on pubsub < 2.0, you'll have to rewrite some pubsub code")


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org