[GitHub] [dolphinscheduler] kezhenxu94 commented on issue #9675: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh

[GitBox <gi...@apache.org>]

kezhenxu94 commented on issue #9675:
URL: https://github.com/apache/dolphinscheduler/issues/9675#issuecomment-1107996038

   > ### Description
   > * In the latest code, we have `dolphinscheduler_env.sh` to set environment variables. However, a few default values are missing. https://github.com/apache/dolphinscheduler/blob/88d2803fe1bd59b1fa719e3cddce1a9e7d1313e8/script/env/dolphinscheduler_env.sh#L33-L36
   
   Because we don't need to set these default, there default values are in `application.yaml`, we just `export` them so that they can be passed down to the start up script.
   
   > * BTW, after building the project, we will have `./tools/bin/dolphinscheduler_env.sh` and `./bin/env/dolphinscheduler_env.sh`. May I ask why we need both of them?
   
   `./bin/env/dolphinscheduler_env.sh` is used when you install all the components in a single machine by using `install.sh`, but mostly, in production, you will install each component in separate machine, in that case, you just copy `master-server` to the desired machine and only `./master-server/bin/dolphinscheduler_env.sh` is used, you won't be able to use `./bin/env/dolphinscheduler_env.sh` in that case


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org