You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by gi...@git.apache.org on 2017/05/26 16:19:29 UTC
[GitHub] rafaelweingartner commented on a change in pull request #2113: CLOUDSTACK-9162: Handled vpn user add when vpn is not enabled on the?
rafaelweingartner commented on a change in pull request #2113: CLOUDSTACK-9162: Handled vpn user add when vpn is not enabled on the?
URL: https://github.com/apache/cloudstack/pull/2113#discussion_r118737579
##########
File path: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java
##########
@@ -508,6 +508,12 @@ public boolean applyVpnUsers(long vpnOwnerId, String userName) throws ResourceU
s_logger.debug("Applying vpn users for " + owner);
List<RemoteAccessVpnVO> vpns = _remoteAccessVpnDao.findByAccount(vpnOwnerId);
+
+ if (vpns != null && vpns.size() == 0) {
Review comment:
What about using `org.apache.commons.collections.CollectionUtils.isEmpty(Collection)` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services