You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/26 19:14:56 UTC

[GitHub] [beam] Abacn opened a new issue, #23373: [Task]: Complete support for logical types that require arguments in Python SDK

Abacn opened a new issue, #23373:
URL: https://github.com/apache/beam/issues/23373

   ### What needs to happen?
   
   Code location: https://github.com/apache/beam/blob/3a4d57eb8976c5f503b32d478a80b1800490f66f/sdks/python/apache_beam/typehints/schemas.py#L270
   
   We can reuse the logic of option_from_runner_api and option_to_runner_api below to parse argument values.
   
   ### Issue Priority
   
   Priority: 2
   
   ### Issue Component
   
   Component: cross-language


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Task]: Complete support for logical types that require arguments in Python SDK [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on issue #23373:
URL: https://github.com/apache/beam/issues/23373#issuecomment-3184423380

   The latest status is that logical type with primitive argument are supported. This should be sufficient for Timestamp(int) type.
   
   https://github.com/apache/beam/blob/b63fb6fd6621ae67b74810ec2351ecddc8981df7/sdks/python/apache_beam/typehints/schemas.py#L455
   
   https://github.com/apache/beam/blob/b63fb6fd6621ae67b74810ec2351ecddc8981df7/sdks/python/apache_beam/typehints/schemas.py#L369
   
   The missing part is the SchemaTranslation of logical type that has non-primitive argument (e.g. Row, array) from Python Row schema -> runner api schema


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Task]: Complete support for logical types that require arguments in Python SDK [beam]

Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on issue #23373:
URL: https://github.com/apache/beam/issues/23373#issuecomment-3184226851

   @Abacn do you remember what work is left to do here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org