You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/03 13:53:15 UTC

[GitHub] [cloudstack] ustcweizhou opened a new pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

ustcweizhou opened a new pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303


   ## Description
   <!--- Describe your changes in detail -->
   
   When use Ubuntu 20.04 as hypervisor, and create an advanced zone with security groups, the systemvms (ssvm and cpvm) will be started but the cloud service will not be Up.
   
   in /var/log/cloud.log, it says vm is unable to connect to management server on port 8250.
   
   Later I found there is caused by a iptables rule below
   ```
   -A BF-cloudbr0 -m physdev --physdev-out ens3: --physdev-is-bridged -j ACCEPT
   ```
   
   The physical device should be "ens3" and "ens3:", which comes from
   ```
   root@node62:~# bridge -o link show | awk '/master cloudbr0 / && !/^[0-9]+: vnet/ {print $2}' | head -1
   ens3:
   ```
   There is no issue with ubuntu 16.04
   ```
   root@node12:~# bridge -o link show | awk '/master cloudbr0 / && !/^[0-9]+: vnet/ {print $2}' | head -1
   eth0
   ```
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-695983804


   ping @weizhouapache @ustcweizhou @davidjumani @shwstppr 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-695983804


   ping @weizhouapache @ustcweizhou @davidjumani @shwstppr 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-687650429


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-696681517






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#discussion_r483546300



##########
File path: scripts/vm/network/security_group.py
##########
@@ -185,7 +185,7 @@ def destroy_network_rules_for_nic(vm_name, vm_ip, vm_mac, vif, sec_ips):
         logging.debug("Ignoring failure to delete ebtable rules for vm: " + vm_name)
 
 def get_bridge_physdev(brname):
-    physdev = execute("bridge -o link show | awk '/master %s / && !/^[0-9]+: vnet/ {print $2}' | head -1" % brname)
+    physdev = execute("bridge -o link show | awk '/master %s / && !/^[0-9]+: vnet/ {print $2}' | head -1 | cut -d ':' -f1" % brname)

Review comment:
       Should we use `ip` (iproute2) instead of old tools?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] wido commented on a change in pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
wido commented on a change in pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#discussion_r483560455



##########
File path: scripts/vm/network/security_group.py
##########
@@ -185,7 +185,7 @@ def destroy_network_rules_for_nic(vm_name, vm_ip, vm_mac, vif, sec_ips):
         logging.debug("Ignoring failure to delete ebtable rules for vm: " + vm_name)
 
 def get_bridge_physdev(brname):
-    physdev = execute("bridge -o link show | awk '/master %s / && !/^[0-9]+: vnet/ {print $2}' | head -1" % brname)
+    physdev = execute("bridge -o link show | awk '/master %s / && !/^[0-9]+: vnet/ {print $2}' | head -1 | cut -d ':' -f1" % brname)

Review comment:
       bridge is a part of iproute2. The old tool is called 'brctl'




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-689523680


   <b>Trillian test result (tid-2700)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 99396 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4303-t2700-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_deployment_planner.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 72 look OK, 13 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 438.18 | test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 678.24 | test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 363.77 | test_internal_lb.py
   test_01_add_delete_kubernetes_supported_version | `Error` | 1807.43 | test_kubernetes_supported_versions.py
   test_isolate_network_password_server | `Failure` | 176.21 | test_password_server.py
   test_01_add_primary_storage_disabled_host | `Error` | 36.91 | test_primary_storage.py
   test_02_vpc_privategw_static_routes | `Failure` | 540.15 | test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 523.67 | test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 829.16 | test_privategw_acl.py
   test_02_isolate_network_FW_PF_default_routes_egress_false | `Failure` | 288.19 | test_routers_network_ops.py
   test_01_sys_vm_start | `Failure` | 0.07 | test_secondary_storage.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
   test_01_deploy_vm_on_specific_host | `Error` | 88.29 | test_vm_deployment_planner.py
   test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 8.42 | test_vm_deployment_planner.py
   test_11_migrate_vm | `Error` | 9.41 | test_vm_life_cycle.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 760.54 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 4039.34 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 1130.73 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 1168.39 | test_vpc_redundant.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 3691.45 | test_vpc_vpn.py
   ContextSuite context=TestRVPCSite2SiteVpn>:teardown | `Error` | 4262.22 | test_vpc_vpn.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 302.65 | test_hostha_kvm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] wido commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
wido commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-687071677


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-687650307


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] wido commented on a change in pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
wido commented on a change in pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#discussion_r483460723



##########
File path: scripts/vm/network/security_group.py
##########
@@ -510,7 +510,7 @@ def check_default_network_rules(vm_name, vm_id, vm_ip, vm_ip6, vm_mac, vif, brna
         rules = execute("iptables-save |grep -w %s |grep -w %s |grep -w %s" % (brfw, vif, vmchain_default))
     except:
         rules = None
-    if rules is None or rules is "":
+    if rules is None or rules == "":

Review comment:
       Maybe better to change this to:
   
   <pre>if not rules:</pre>
   
   That captures the None and empty string case right away.

##########
File path: scripts/vm/network/security_group.py
##########
@@ -185,7 +185,7 @@ def destroy_network_rules_for_nic(vm_name, vm_ip, vm_mac, vif, sec_ips):
         logging.debug("Ignoring failure to delete ebtable rules for vm: " + vm_name)
 
 def get_bridge_physdev(brname):
-    physdev = execute("bridge -o link show | awk '/master %s / && !/^[0-9]+: vnet/ {print $2}' | head -1" % brname)
+    physdev = execute("bridge -o link show | awk '/master %s / && !/^[0-9]+: vnet/ {print $2}' | head -1 | cut -d ':' -f1" % brname)

Review comment:
       Do we know what changed in Ubuntu 20.04? As the '-o' flag should make it stable to use on the CLI




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-688801446


   cc @davidjumani can you review?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-687655566






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-696681517


   ping @davidjumani can you try again?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-696326464


   > qemu-system-x86_64: error: failed to set MSR 0xe1 to 0x0
   
   @davidjumani 
   I do not have this issue on my testing env.
   
   are you using nested virtualization on a host with AMD cpu ?
   you can try this workaround
   ```
   echo 1 > /sys/modules/kvm/parameters/ignore_msrs
   ```
   see https://patchwork.kernel.org/patch/42605/ for more details


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-696326464


   > qemu-system-x86_64: error: failed to set MSR 0xe1 to 0x0
   
   @davidjumani 
   I do not have this issue on my testing env.
   
   are you using nested virtualization on a host with AMD cpu ?
   you can try this workaround
   ```
   echo 1 > /sys/modules/kvm/parameters/ignore_msrs
   ```
   see https://patchwork.kernel.org/patch/42605/ for more details


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-693234165


   @ustcweizhou can you test in your env and provide results?
   @davidjumani can you test manually and see if it works/doesn't work?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-688090097


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1907


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-687650060


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#discussion_r483475998



##########
File path: scripts/vm/network/security_group.py
##########
@@ -510,7 +510,7 @@ def check_default_network_rules(vm_name, vm_id, vm_ip, vm_ip6, vm_mac, vif, brna
         rules = execute("iptables-save |grep -w %s |grep -w %s |grep -w %s" % (brfw, vif, vmchain_default))
     except:
         rules = None
-    if rules is None or rules is "":
+    if rules is None or rules == "":

Review comment:
       good, thanks @wido 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] abdelouahabb commented on a change in pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
abdelouahabb commented on a change in pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#discussion_r559864445



##########
File path: scripts/vm/network/security_group.py
##########
@@ -185,7 +185,7 @@ def destroy_network_rules_for_nic(vm_name, vm_ip, vm_mac, vif, sec_ips):
         logging.debug("Ignoring failure to delete ebtable rules for vm: " + vm_name)
 
 def get_bridge_physdev(brname):
-    physdev = execute("bridge -o link show | awk '/master %s / && !/^[0-9]+: vnet/ {print $2}' | head -1" % brname)
+    physdev = execute("bridge -o link show | awk '/master %s / && !/^[0-9]+: vnet/ {print $2}' | head -1 | cut -d ':' -f1" % brname)

Review comment:
       there is the trick to use `ls /sys/class/net` to get the exact interface names




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#discussion_r483476837



##########
File path: scripts/vm/network/security_group.py
##########
@@ -185,7 +185,7 @@ def destroy_network_rules_for_nic(vm_name, vm_ip, vm_mac, vif, sec_ips):
         logging.debug("Ignoring failure to delete ebtable rules for vm: " + vm_name)
 
 def get_bridge_physdev(brname):
-    physdev = execute("bridge -o link show | awk '/master %s / && !/^[0-9]+: vnet/ {print $2}' | head -1" % brname)
+    physdev = execute("bridge -o link show | awk '/master %s / && !/^[0-9]+: vnet/ {print $2}' | head -1 | cut -d ':' -f1" % brname)

Review comment:
       @wido here is an example
   in ubuntu 16.04
   ```
   root@node42:~# bridge -o link show
   2: eth0 state UP : <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 master cloudbr0 state forwarding priority 32 cost 100
   ```
   in ubuntu 20.04
   ```
   root@node62:~# bridge -o link show
   2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 master cloudbr0 state forwarding priority 32 cost 100
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-688065231


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-688491423


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-693184140


   Systemvm is still unable to come up on u20, but i think that it might be unrelated
   ```
   2020-09-16 05:00:45,295 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-5:null) (logid:287cef54) Trying to fetch storage pool 0e678d73-abb2-3295-b6c3-b6949a8a2f8d from libvirt
   2020-09-16 05:00:48,388 INFO  [kvm.resource.LibvirtConnection] (agentRequest-Handler-1:null) (logid:287cef54) No existing libvirtd connection found. Opening a new one
   2020-09-16 05:00:48,389 WARN  [kvm.resource.LibvirtConnection] (agentRequest-Handler-1:null) (logid:287cef54) Can not find a connection for Instance s-61-VM. Assuming the default connection.
   2020-09-16 05:00:48,461 WARN  [kvm.resource.LibvirtKvmAgentHook] (agentRequest-Handler-1:null) (logid:287cef54) Groovy script '/etc/cloudstack/agent/hooks/libvirt-vm-state-change.groovy' is not available. Transformations will not be applied.
   2020-09-16 05:00:48,461 WARN  [kvm.resource.LibvirtKvmAgentHook] (agentRequest-Handler-1:null) (logid:287cef54) Groovy scripting engine is not initialized. Data transformation skipped.
   2020-09-16 05:01:18,900 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-2:null) (logid:3d0925b0) Trying to fetch storage pool 0e678d73-abb2-3295-b6c3-b6949a8a2f8d from libvirt
   2020-09-16 05:01:18,955 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-2:null) (logid:3d0925b0) Attempting to remove volume a2fcc05f-2abd-44a5-a3cf-2474232dac1f from pool 0e678d73-abb2-3295-b6c3-b6949a8a2f8d
   2020-09-16 05:01:43,249 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-4:null) (logid:287cef54) Trying to fetch storage pool fb4bb1df-cb02-3dfe-9a79-d37ee241d200 from libvirt
   2020-09-16 05:01:43,252 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-4:null) (logid:287cef54) Trying to fetch storage pool fb4bb1df-cb02-3dfe-9a79-d37ee241d200 from libvirt
   2020-09-16 05:01:43,264 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-4:null) (logid:287cef54) Creating volume 96de7039-b33f-4dc3-9381-dc62f19dc4f2 from template 01e1c91c-f125-42b7-8e95-3d5145c0d0b3 in pool fb4bb1df-cb02-3dfe-9a79-d37ee241d200 (NetworkFilesystem) with size (0 bytes) 0
   2020-09-16 05:01:43,265 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-4:null) (logid:287cef54) Attempting to create volume 96de7039-b33f-4dc3-9381-dc62f19dc4f2 (NetworkFilesystem) in pool fb4bb1df-cb02-3dfe-9a79-d37ee241d200 with size (2.44 GB) 2621440000
   2020-09-16 05:01:43,778 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-5:null) (logid:287cef54) Trying to fetch storage pool fb4bb1df-cb02-3dfe-9a79-d37ee241d200 from libvirt
   2020-09-16 05:01:43,814 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-5:null) (logid:287cef54) Trying to fetch storage pool fb4bb1df-cb02-3dfe-9a79-d37ee241d200 from libvirt
   2020-09-16 05:01:43,859 WARN  [kvm.resource.LibvirtKvmAgentHook] (agentRequest-Handler-5:null) (logid:287cef54) Groovy script '/etc/cloudstack/agent/hooks/libvirt-vm-xml-transformer.groovy' is not available. Transformations will not be applied.
   2020-09-16 05:01:43,859 WARN  [kvm.resource.LibvirtKvmAgentHook] (agentRequest-Handler-5:null) (logid:287cef54) Groovy scripting engine is not initialized. Data transformation skipped.
   2020-09-16 05:01:44,655 WARN  [resource.wrapper.LibvirtStartCommandWrapper] (agentRequest-Handler-5:null) (logid:287cef54) LibvirtException 
   org.libvirt.LibvirtException: internal error: qemu unexpectedly closed the monitor: 2020-09-16T05:01:44.138805Z qemu-system-x86_64: error: failed to set MSR 0xe1 to 0x0
   qemu-system-x86_64: /build/qemu-J4cYl4/qemu-4.2/target/i386/kvm.c:2691: kvm_buf_set_msrs: Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed.
   	at org.libvirt.ErrorHandler.processError(Unknown Source)
   	at org.libvirt.Connect.processError(Unknown Source)
   	at org.libvirt.Connect.processError(Unknown Source)
   	at org.libvirt.Connect.domainCreateXML(Unknown Source)
   	at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.startVM(LibvirtComputingResource.java:1612)
   	at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtStartCommandWrapper.execute(LibvirtStartCommandWrapper.java:85)
   	at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtStartCommandWrapper.execute(LibvirtStartCommandWrapper.java:45)
   	at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtRequestWrapper.execute(LibvirtRequestWrapper.java:78)
   	at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(LibvirtComputingResource.java:1644)
   	at com.cloud.agent.Agent.processRequest(Agent.java:645)
   	at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:1063)
   	at com.cloud.utils.nio.Task.call(Task.java:83)
   	at com.cloud.utils.nio.Task.call(Task.java:29)
   	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
   	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
   	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
   	at java.base/java.lang.Thread.run(Thread.java:834)
   2020-09-16 05:01:44,779 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-5:null) (logid:287cef54) Trying to fetch storage pool fb4bb1df-cb02-3dfe-9a79-d37ee241d200 from libvirt
   2020-09-16 05:01:48,900 INFO  [kvm.resource.LibvirtConnection] (agentRequest-Handler-1:null) (logid:287cef54) No existing libvirtd connection found. Opening a new one
   2020-09-16 05:01:48,901 WARN  [kvm.resource.LibvirtConnection] (agentRequest-Handler-1:null) (logid:287cef54) Can not find a connection for Instance s-62-VM. Assuming the default connection.
   2020-09-16 05:01:48,970 WARN  [kvm.resource.LibvirtKvmAgentHook] (agentRequest-Handler-1:null) (logid:287cef54) Groovy script '/etc/cloudstack/agent/hooks/libvirt-vm-state-change.groovy' is not available. Transformations will not be applied.
   2020-09-16 05:01:48,971 WARN  [kvm.resource.LibvirtKvmAgentHook] (agentRequest-Handler-1:null) (logid:287cef54) Groovy scripting engine is not initialized. Data transformation skipped.
   2020-09-16 05:02:13,275 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-2:null) (logid:57bb906e) Trying to fetch storage pool 0e678d73-abb2-3295-b6c3-b6949a8a2f8d from libvirt
   2020-09-16 05:02:13,299 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-2:null) (logid:57bb906e) Trying to fetch storage pool 0e678d73-abb2-3295-b6c3-b6949a8a2f8d from libvirt
   2020-09-16 05:02:13,344 WARN  [kvm.resource.LibvirtKvmAgentHook] (agentRequest-Handler-2:null) (logid:57bb906e) Groovy script '/etc/cloudstack/agent/hooks/libvirt-vm-xml-transformer.groovy' is not available. Transformations will not be applied.
   2020-09-16 05:02:13,344 WARN  [kvm.resource.LibvirtKvmAgentHook] (agentRequest-Handler-2:null) (logid:57bb906e) Groovy scripting engine is not initialized. Data transformation skipped.
   2020-09-16 05:02:14,100 WARN  [resource.wrapper.LibvirtStartCommandWrapper] (agentRequest-Handler-2:null) (logid:57bb906e) LibvirtException 
   org.libvirt.LibvirtException: internal error: qemu unexpectedly closed the monitor: 2020-09-16T05:02:13.656588Z qemu-system-x86_64: error: failed to set MSR 0xe1 to 0x0
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-688064798


   @blueorangutan package
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-688491927


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-689983630


   Changes LGTM. Will test!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4303: Ubuntu 20.04: Fix systemvm cannot start up

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4303:
URL: https://github.com/apache/cloudstack/pull/4303#issuecomment-696795531


   Merged based on Wido and David 's lgtms


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org