[GitHub] [iceberg] stevenzwu edited a comment on issue #4137: Flink Job failed to restore because of downstream table changed

[GitBox <gi...@apache.org>]

stevenzwu edited a comment on issue #4137:
URL: https://github.com/apache/iceberg/issues/4137#issuecomment-1048415756


   @coolderli is my understanding below correct?
   
   Regarding `getMaxCommittedCheckpointId`, I guess you are saying that the snapshot containing the last commited checkpointId expired and hence `getMaxCommittedCheckpointId` returns -1. I agree that in this case we shouldn't try to execute `commitUpToCheckpoint` since we don't safely know what is the last committed checkpoint id. 
   
   It can result in duplicates in this case if the manifest file wasn't cleaned up after successful commit.  Because the checkpointed manifest file was deleted, we can also conclude that the last Iceberg commit succeeded already.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org