[GitHub] [ozone] jojochuang commented on a diff in pull request #4406: HDDS-7994. Expose information via the ClusterState endpoint on keys and Directories marked for deletion

["jojochuang (via GitHub)" <gi...@apache.org>]

jojochuang commented on code in PR #4406:
URL: https://github.com/apache/ozone/pull/4406#discussion_r1151217385


##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestEndpoints.java:
##########
@@ -366,25 +370,19 @@ public void setUp() throws Exception {
     } catch (Exception ex) {
       Assertions.fail(ex.getMessage());
     }
-
     // Write Data to OM
-
     // A sample volume (sampleVol) and a bucket (bucketOne) is already created
     // in AbstractOMMetadataManagerTest.
     // Create a new volume and bucket and then write keys to the bucket.
     String volumeKey = reconOMMetadataManager.getVolumeKey("sampleVol2");
     OmVolumeArgs args =
         OmVolumeArgs.newBuilder()
-            .setVolume("sampleVol2")
-            .setAdminName("TestUser")
-            .setOwnerName("TestUser")
-            .build();
+            .setVolume("sampleVol2").setAdminName("TestUser")
+            .setOwnerName("TestUser").build();

Review Comment:
   It's usually a convention to have one setter per line to use a builder. No need to change these.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org