You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/20 02:02:15 UTC

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1080: Update schema to master

juzhiyuan commented on a change in pull request #1080:
URL: https://github.com/apache/apisix-dashboard/pull/1080#discussion_r546308315



##########
File path: api/conf/schema.json
##########
@@ -3240,6 +3285,12 @@
 				"type": "object"
 			}
 		},
+		"server-info": {

Review comment:
       How about the `attr_schema`?
   
   https://github.com/apache/apisix/blob/9a07ee8f825dcc428e9255096629ad74e7968d1c/apisix/plugins/server-info.lua#L35-L53
   
   ```
   local attr_schema = {
       type = "object",
       properties = {
           report_interval = {
               type = "integer",
               description = "server info reporting interval (unit: second)",
               default = default_report_interval,
               minimum = 60,
               maximum = 3600,
           },
           report_ttl = {
               type = "integer",
               description = "live time for server info in etcd",
               default = default_report_ttl,
               minimum = 3600,
               maximum = 86400,
           }
       }
   }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org