You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2023/12/23 18:16:30 UTC

[I] CSV WriterBuilder should expose `timestamp_tz_format` field [arrow-datafusion]

andygrove opened a new issue, #8640:
URL: https://github.com/apache/arrow-datafusion/issues/8640

   ### Is your feature request related to a problem or challenge?
   
   There are no set/get methods for the field `timestamp_tz_format`. I don't know if this is intentional or just an oversight. If it is intentional then it would be good to add a comment explaining the rationale.
   
   ### Describe the solution you'd like
   
   _No response_
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] CSV WriterBuilder should expose `timestamp_tz_format` field [arrow-datafusion]

Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on issue #8640:
URL: https://github.com/apache/arrow-datafusion/issues/8640#issuecomment-1868346090

   @devinjdangelo fyi


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] CSV WriterBuilder should expose `timestamp_tz_format` field [arrow-datafusion]

Posted by "razeghi71 (via GitHub)" <gi...@apache.org>.
razeghi71 commented on issue #8640:
URL: https://github.com/apache/arrow-datafusion/issues/8640#issuecomment-1873513109

   I can work on this. Just to clarify this need this needs to be implemented in `arrow-csv` right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] CSV WriterBuilder should expose `timestamp_tz_format` field [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #8640:
URL: https://github.com/apache/arrow-datafusion/issues/8640#issuecomment-1871487537

   I think this would be a good first issue for someone to help out with if they wanted


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] CSV WriterBuilder should expose `timestamp_tz_format` field [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #8640:
URL: https://github.com/apache/arrow-datafusion/issues/8640#issuecomment-1874183003

   I did some poking around, and while I actually think the relevant `timestamp_tz_format` field already exists in arrow:
   https://github.com/apache/arrow-rs/blob/b2b4e7a44f814ac5f9d20886171ea20b2dd8a30f/arrow-csv/src/writer.rs#L128
   
   It doesn't seem to be able to be set it.
   
   So maybe the first thing to do is to figure out if that is an important setting to control for csv writing and if so, expose its configuration in arrow-rs.
   
   Then this  ticket would entail connecting it up to datafusion, similarly to how `date_format` and `time_format` are exposed: https://github.com/apache/arrow-datafusion/blob/bf0a39a791e7cd0e965abb8c87950cc4101149f7/datafusion/common/src/file_options/csv_writer.rs#L69C1-L74


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org