You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "alliasgher (via GitHub)" <gi...@apache.org> on 2026/04/13 18:13:10 UTC

[PR] fix(amazon): extend SQS QUEUE_REGEXP to match AWS China endpoints [airflow]

alliasgher opened a new pull request, #65173:
URL: https://github.com/apache/airflow/pull/65173

   ## What does this PR do?
   
   `QUEUE_REGEXP` only matched `amazonaws.com` domains, so `SqsMessageQueueProvider.queue_matches()` returned `False` for AWS China region URLs such as:
   
   ```
   https://sqs.cn-north-1.amazonaws.cn/123456789012/my-queue
   ```
   
   Extends the regex to accept `amazonaws.cn` as an alternate domain suffix, supporting China regions `cn-north-1` and `cn-northwest-1`.
   
   Fixes #65128
   
   ## Are there any user-facing changes?
   
   SQS queue URLs in AWS China regions are now correctly recognised by the `SqsMessageQueueProvider`.
   
   ## Checklist
   
   - [x] Added test cases for `cn-north-1` and `cn-northwest-1` China region URLs in `test_message_sqs_queue_matches`
   
   Signed-off-by: Ali <al...@gmail.com>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(amazon): extend SQS QUEUE_REGEXP to match AWS China endpoints [airflow]

Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #65173:
URL: https://github.com/apache/airflow/pull/65173


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(amazon): extend SQS QUEUE_REGEXP to match AWS China endpoints [airflow]

Posted by "crazy-canux (via GitHub)" <gi...@apache.org>.
crazy-canux commented on PR #65173:
URL: https://github.com/apache/airflow/pull/65173#issuecomment-4249607486

   thanks for quick fix.
   but https://sqs.cn-northwest-1.amazonaws.com.cn/123456/my_sqs is the right domain.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(amazon): extend SQS QUEUE_REGEXP to match AWS China endpoints [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #65173:
URL: https://github.com/apache/airflow/pull/65173#issuecomment-4244541649

   Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org