[GitHub] [nifi-registry] kevdoran commented on a change in pull request #163: NIFIREG-233 Setup ExtensionDocWriter with HTML implementation and RES…

[GitBox <gi...@apache.org>]

kevdoran commented on a change in pull request #163: NIFIREG-233 Setup ExtensionDocWriter with HTML implementation and RES…
URL: https://github.com/apache/nifi-registry/pull/163#discussion_r271066238
 
 

 ##########
 File path: nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/extension/component/ExtensionMetadata.java
 ##########
 @@ -123,6 +130,28 @@ public void setBundleInfo(BundleInfo bundleInfo) {
         this.bundleInfo = bundleInfo;
     }
 
+    @ApiModelProperty(value = "Whether or not the extension has additional detail documentation")
+    public boolean getHasAdditionalDetails() {
+        return hasAdditionalDetails;
+    }
+
+    public void setHasAdditionalDetails(boolean hasAdditionalDetails) {
+        this.hasAdditionalDetails = hasAdditionalDetails;
+    }
+
+    @Override
+    @XmlElement
+    @XmlJavaTypeAdapter(LinkAdapter.class)
+    @ApiModelProperty(value = "A WebLink to the documentation for this extension.", readOnly = true)
+    public Link getLinkDocs() {
 
 Review comment:
   I know we already have Link as a field type in DTO for self-links, but I think we need to come up with something that works better with Swagger, as the `Link` abstract class is not well suited as a Swagger DTO type. I've opened [NIFIREG-248](https://issues.apache.org/jira/browse/NIFIREG-248) to capture the details of this.
   
   I don't think this necessarily needs to be fixed in this PR, although it might be good to tackle before v0.4.0 is released.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services