[jira] Closed: (OFBIZ-2596) categorydetail.ftl page select drop-down and pagination is not compatible with new screen called categorydetailmatrix.ftl. [Screen uses 3 columns per row to display products vs 1 column per row from older versions.]

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2596.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
                   Release Branch 9.04
         Assignee: Jacques Le Roux

Ruth,

I have tried your changes with 19 products and it works well. So i commited in trunk at r811860 and R9.04 at r 811861
A small change (only the 2d change was needed) and a great improvment :)

> categorydetail.ftl page select drop-down and pagination is not compatible with new screen called categorydetailmatrix.ftl. [Screen uses 3 columns per  row to display products vs 1 column per row from older versions.] 
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2596
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2596
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>         Environment: Proposed change to the ~order/webapp/ordermgr/catalog/categorydetail.ftl screen
>            Reporter: Ruth Hoffman
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: 2596-categorylist.jpg, 2596-ecommercelist.jpg
>
>
> First, someone should test this before committing! This is only a suggested change.
> See comments for more info info:
> Around line 23:
> Change: 
> <#if (viewIndexMax?int > 0)>
> To:
> <#-- if the list size/view size (that is total number of items allowed on the page  for this page)
>          is 0 or 1 then there is only 1 page of items - so display the pagination drop down anyhow 
>          'cause its cool and people should see it.
>  -->
>   <#if (viewIndexMax?int > -1)>
> If you change that then, the listSize number following this doesn't make sense - on the demo screen it displays "1 of 9" so,
> I propose that you also change line 37 from:
> <#if (listSize?int > 0) > 
> To something like:
>  <#if ((listSize?int - viewSize?int) > 0)> 
> so that the other text is not displayed in this case.
> Not sure how multipage, 3 column listings will render, but this will at least make the display for the demo store show pagination.
> Maybe someone who has more recent experience with this part of Freemarker pages can look at this really quickly and assess the impact overall.
> Thanks
> Ruth

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.